Bug 32863 - Fix cataloguing/value_builder/unimarc_field_140.pl
Summary: Fix cataloguing/value_builder/unimarc_field_140.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 13:50 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl (1.48 KB, patch)
2023-02-03 13:51 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl (1.52 KB, patch)
2023-02-17 10:17 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl (1.57 KB, patch)
2023-03-27 22:56 UTC, David Nind
Details | Diff | Splinter Review
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl (1.62 KB, patch)
2023-03-29 08:42 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 13:50:31 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:51:12 UTC
Created attachment 146128 [details] [review]
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:17:12 UTC
Created attachment 146799 [details] [review]
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-27 22:56:48 UTC
Created attachment 148789 [details] [review]
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-27 22:58:00 UTC
How I tested
~~~~~~~~~~~~

1. The plugin unimarc_field_140.pl is already added to subfield 140$a for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.
Comment 5 Nick Clemens 2023-03-29 08:42:11 UTC
Created attachment 148882 [details] [review]
Bug 32863: Fix cataloguing/value_builder/unimarc_field_140.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-03-30 10:32:43 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-11 11:12:46 UTC
Nice work everyone!

Pushed to stable for 22.11.x