Bug 32865 - Clean up cataloguing/value_builder/unimarc_field_146a.pl
Summary: Clean up cataloguing/value_builder/unimarc_field_146a.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 13:54 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl (1.08 KB, patch)
2023-02-03 13:54 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl (1.13 KB, patch)
2023-03-28 18:46 UTC, David Nind
Details | Diff | Splinter Review
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl (1.18 KB, patch)
2023-04-22 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 13:54:01 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:54:40 UTC
Created attachment 146130 [details] [review]
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-06 15:48:36 UTC
This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible.
Comment 3 David Nind 2023-03-27 23:09:21 UTC
I'm sure there is a reason that this has "Depends on: 30975" instead of "Blocks: 30975" like most of the other bugs for this change.

While it is a bit tedious to say "y" to all the depends on bugs, it eventually fails when applying bug 30975.
Comment 4 David Nind 2023-03-27 23:21:37 UTC
I originally didn't read comment #2 - please ignore comment #3!
Comment 5 David Nind 2023-03-28 18:46:42 UTC
Created attachment 148843 [details] [review]
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-03-28 18:50:44 UTC
How I tested
~~~~~~~~~~~~

1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs.
2. Remove the authorized value list currently used for 146$a in KTD.
3. Add the plugin unimarc_field_146a.pl to subfield 146$a for the default UNIMARC bibliographic framework in KTD.
4. Edit a bibliographic record.
5. Select the tag editor for the subfield.
6. Options and values should be the same before and after the patch is applied.

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.
Comment 7 Katrin Fischer 2023-04-22 21:42:11 UTC
Created attachment 150099 [details] [review]
Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Victor Grousset/tuxayo 2023-04-24 01:44:36 UTC
Thanks Katrin, you beat me to it :)

I confirm the that the plugin continues to work as before.
Comment 9 Tomás Cohen Arazi 2023-04-24 13:49:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-05-10 12:53:58 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.