Bug 32866 - Clean up cataloguing/value_builder/unimarc_field_146h.pl
Summary: Clean up cataloguing/value_builder/unimarc_field_146h.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 13:55 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl (1.08 KB, patch)
2023-02-03 13:56 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl (1.13 KB, patch)
2023-03-28 18:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl (1.18 KB, patch)
2023-04-22 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 13:55:43 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:56:38 UTC
Created attachment 146131 [details] [review]
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-06 15:49:31 UTC
This one is actually only a cleanup patch that is not needed for bug 30975, but bug 30975 is needed for the cleanup to be possible.
Comment 3 David Nind 2023-03-28 18:55:33 UTC
Created attachment 148844 [details] [review]
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-28 18:58:16 UTC
How I tested
~~~~~~~~~~~~

1. Applied bug 30975 (interactive, commented out the first patch) - this takes a while as you have to say yes to all the dependent bugs.
2. Added the plugin unimarc_field_146h.pl to subfield 146$h for the default UNIMARC bibliographic framework in KTD.
3. Edit a bibliographic record.
4. Select the tag editor for the subfield.
5. Options and values should be the same before and after the patch is applied.

Bonus: With bug 30975 applied, cloning subfields and using the tag editor on the cloned subfield now works as expected!

Description
~~~~~~~~~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield.
Comment 5 Katrin Fischer 2023-04-22 21:37:06 UTC
Created attachment 150098 [details] [review]
Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl

Remove unnecessary call to event.preventDefault()

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-04-24 13:49:21 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 12:54:01 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.