Bug 32870 - Fix cataloguing/value_builder/unimarc_field_225a_bis.pl
Summary: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency tree / graph
 
Reported: 2023-02-03 14:00 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:

Attachments
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl (1.37 KB, patch)
2023-02-03 14:01 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl (1.41 KB, patch)
2023-02-17 10:17 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl (1.46 KB, patch)
2023-04-22 22:20 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 14:00:58 UTC 
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:01:24 UTC 
Created attachment 146136 [details] [review]
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:17:55 UTC 
Created attachment 146803 [details] [review]
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-30 19:42:23 UTC 
I'm not familiar enough with UNIMARC to figure out how to use this plugin.

Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does.

Thanks!

David
Comment 4 Katrin Fischer 2023-04-22 22:19:46 UTC 
This is an auto-complete search for existing series in the database. "Libre" will work for a test.
Comment 5 Katrin Fischer 2023-04-22 22:20:55 UTC 
Created attachment 150106 [details] [review]
Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-04-22 22:21:28 UTC 
'coll' will work even better on the sample test data :)

Straight through to PQA.
Comment 7 David Nind 2023-04-22 23:04:59 UTC 
(In reply to Katrin Fischer from comment #4)
> This is an auto-complete search for existing series in the database. "Libre"
> will work for a test.

Thanks Katrin!
Comment 8 Tomás Cohen Arazi (tcohen) 2023-04-24 13:49:36 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-05-10 12:54:15 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.