Bug 32876 - Fix cataloguing/value_builder/unimarc_leader.pl
Summary: Fix cataloguing/value_builder/unimarc_leader.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 14:11 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:


Attachments
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl (1.87 KB, patch)
2023-02-03 14:12 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl (1.91 KB, patch)
2023-02-17 10:18 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl (1.95 KB, patch)
2023-03-30 19:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl (2.01 KB, patch)
2023-04-22 20:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 14:11:48 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:12:25 UTC
Created attachment 146143 [details] [review]
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:18:59 UTC
Created attachment 146810 [details] [review]
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-30 19:35:23 UTC
Created attachment 149007 [details] [review]
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-03-30 19:38:46 UTC
How I tested
~~~~~~~~~~~~

1. The plugin is already added to 000$00 for the default UNIMARC bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for 000$00.
4. Options and values should be the same before and after the patch is applied.
5. The auto-calculated parts are calculated when the record is saved.

Description
~~~~~~~~~~~

This displays a form to select the values that make up a bibiographic record header (000). Note that the auto-calculated parts for the header are calculated when the record is saved.
Comment 5 Katrin Fischer 2023-04-22 20:52:31 UTC
Created attachment 150091 [details] [review]
Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-04-24 13:49:54 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-05-10 12:54:31 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.