Bug 32886 - Set focus for cursor to Code when adding a new restriction
Summary: Set focus for cursor to Code when adding a new restriction
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 31411
  Show dependency treegraph
 
Reported: 2023-02-05 00:26 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32886: Set focus for cursor to Code when adding a new restriction (1.50 KB, patch)
2023-02-07 13:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32886: Set focus for cursor to Code when adding a new restriction (1.58 KB, patch)
2023-02-07 15:46 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32886: Set focus for cursor to Code when adding a new restriction (1.62 KB, patch)
2023-02-24 16:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-05 00:26:32 UTC

    
Comment 1 Katrin Fischer 2023-02-05 00:34:58 UTC
focus class is not working in this case - hints appreciated.
Comment 2 Owen Leonard 2023-02-07 13:43:22 UTC
Created attachment 146330 [details] [review]
Bug 32886: Set focus for cursor to Code when adding a new restriction

This patch adds the "focus" class to the form for defining a new patron
restriction so that the cursor focus is automatically added.

To test, apply the patch and go to Administration -> Patron restrictions
-> New restriction.

The cursor should automatically move to the "Code" input field.
Comment 3 Matt Blenkinsop 2023-02-07 15:46:56 UTC
Created attachment 146336 [details] [review]
Bug 32886: Set focus for cursor to Code when adding a new restriction

This patch adds the "focus" class to the form for defining a new patron
restriction so that the cursor focus is automatically added.

To test, apply the patch and go to Administration -> Patron restrictions
-> New restriction.

The cursor should automatically move to the "Code" input field.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Katrin Fischer 2023-02-24 16:45:00 UTC
(In reply to Katrin Fischer from comment #1)
> focus class is not working in this case - hints appreciated.

Huh, not sure what I did there, it works after all!
Comment 5 Katrin Fischer 2023-02-24 16:45:28 UTC
Created attachment 147363 [details] [review]
Bug 32886: Set focus for cursor to Code when adding a new restriction

This patch adds the "focus" class to the form for defining a new patron
restriction so that the cursor focus is automatically added.

To test, apply the patch and go to Administration -> Patron restrictions
-> New restriction.

The cursor should automatically move to the "Code" input field.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 Tomás Cohen Arazi 2023-03-10 14:14:53 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-10 16:48:45 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-04-14 16:33:01 UTC
Doesn't apply clean in 22.05.x, no backport