Bug 32904 - Patrons table processing eternally and not loading
Summary: Patrons table processing eternally and not loading
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 32030
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-07 22:01 UTC by Aleisha Amohia
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32904: Check if responseJSON is defined for dataTable error (1.34 KB, patch)
2023-02-07 22:03 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 32904: Check if responseJSON is defined for dataTable error (1.42 KB, patch)
2023-02-09 08:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-02-07 22:01:01 UTC
Error in console: Uncaught TypeError: settings.jqXHR.responseJSON is undefined
Comment 1 Aleisha Amohia 2023-02-07 22:03:46 UTC
Created attachment 146362 [details] [review]
Bug 32904: Check if responseJSON is defined for dataTable error

This patch checks if responseJSON is defined before checking if
responseJSON.errors is defined.

Sponsored-by: Education Services Australia SCIS
Comment 2 Aleisha Amohia 2023-02-07 22:05:11 UTC
I'm not sure how to reproduce this or if this is the 'right' fix but it doesn't seem harmful.
Comment 3 Jonathan Druart 2023-02-09 08:47:04 UTC
Created attachment 146418 [details] [review]
Bug 32904: Check if responseJSON is defined for dataTable error

This patch checks if responseJSON is defined before checking if
responseJSON.errors is defined.

Sponsored-by: Education Services Australia SCIS

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-02-22 15:04:01 UTC
Trivial, skipping QA.
Comment 5 Tomás Cohen Arazi 2023-02-27 14:42:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-01 09:51:21 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-03-10 14:27:25 UTC
Not needed in 22.05.x, no backport.