Bug 32912 - Use template wrapper for notices tabs
Summary: Use template wrapper for notices tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks: 33622
  Show dependency tree / graph
 
Reported: 2023-02-08 17:09 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:

Attachments
Bug 32912: Use template wrapper for notices tabs (38.03 KB, patch)
2023-02-08 17:37 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32912: Use template wrapper for notices tabs (38.08 KB, patch)
2023-02-08 18:35 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32912: Use template wrapper for notices tabs (38.14 KB, patch)
2023-02-24 16:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-08 17:09:41 UTC 
Continuing the work of Bug 32571, the notices template should be updated to use the new WRAPPER for tabs.
Comment 1 Owen Leonard 2023-02-08 17:10:15 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-08 17:37:50 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-02-08 18:35:09 UTC 
Created attachment 146407 [details] [review]
Bug 32912: Use template wrapper for notices tabs

This patch updates the notices template to replace tab markup with
the use of WRAPPERs.

This patch also makes a minor correction to the color of Bootstrap
panels.

To test you must have more than one translation installed, and the
TranslateNotices preference should be enabled.

- Apply the patch and go to Tools -> Notices.
- Edit a notice.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
- Disable the TranslateNotices preference to confirm that the
  display is still correct without the tabbed interface.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-02-24 16:55:12 UTC 
Created attachment 147367 [details] [review]
Bug 32912: Use template wrapper for notices tabs

This patch updates the notices template to replace tab markup with
the use of WRAPPERs.

This patch also makes a minor correction to the color of Bootstrap
panels.

To test you must have more than one translation installed, and the
TranslateNotices preference should be enabled.

- Apply the patch and go to Tools -> Notices.
- Edit a notice.
- You should see tabs for each available language, for example
  Default, English, French.
- Test adding content to each language to confirm that the correct
  information is saved under the correct tab.
- Disable the TranslateNotices preference to confirm that the
  display is still correct without the tabbed interface.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-24 19:57:00 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-28 16:40:41 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-03-08 13:27:26 UTC 
Missing dependencies for 22.05.x, no backport.