To recreate: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. This is a problem for some libraries because not every patron realizes there is another action after pressing 'Finish' and they walk away. Leaving open a screen that shows their username and checkouts.
Created attachment 146414 [details] [review] Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires.
(In reply to Lucas Gass from comment #1) > Created attachment 146414 [details] [review] [review] > Bug 32921: Honor SelfCheckTimeout when modal is open > > To test: > 1. Set the 'SelfCheckTimeout' system preference to something low for testing. > 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. > 3. Log in to SCO and press finish but leave the modal open. > 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. > 5. Apply patch and try again. You should be logged out when SelfCheckTimeout > expires. Hi Lucas, I set my SelfCheckTimeout to 10 seconds, left the modal open and it did not log out even after applying the patch.
(In reply to Laura Escamilla from comment #2) > (In reply to Lucas Gass from comment #1) > > Created attachment 146414 [details] [review] [review] [review] > > Bug 32921: Honor SelfCheckTimeout when modal is open > > > > To test: > > 1. Set the 'SelfCheckTimeout' system preference to something low for testing. > > 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. > > 3. Log in to SCO and press finish but leave the modal open. > > 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. > > 5. Apply patch and try again. You should be logged out when SelfCheckTimeout > > expires. > > Hi Lucas, > > I set my SelfCheckTimeout to 10 seconds, left the modal open and it did not > log out even after applying the patch. Hmmm, this does work for me in both Firefox and Chrome. Question, did you try clearing your cache after applying the patch?
Since this is working for me I am going to set it back to NSO to see if I can get some more feedback.
Created attachment 149779 [details] [review] Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
Created attachment 150568 [details] [review] Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> JD amended patch - fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.13