Bug 32935 - basketgroup.js is not longer used and should be removed
Summary: basketgroup.js is not longer used and should be removed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 13614
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-09 23:07 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:

Attachments
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js (12.47 KB, patch)
2023-02-23 08:57 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js (12.53 KB, patch)
2023-02-23 22:37 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js (12.58 KB, patch)
2023-02-24 20:18 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-09 23:07:18 UTC 
Looking into bug 31056 it seems like this file is no longer used anywhere. 
If confirmed, we could remove it.

See also:
Bug 13614: Replace usage of YUI on basket groups page
Comment 1 Jonathan Druart 2023-02-23 08:57:49 UTC 
Created attachment 147194 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything
Comment 2 Katrin Fischer 2023-02-23 22:37:46 UTC 
Created attachment 147278 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Nick Clemens (kidclamp) 2023-02-24 20:18:06 UTC 
Created attachment 147398 [details] [review]
Bug 32935: (bug 13614 follow-up) Remove unused basketgroup.js

Bug 13614 removed it. On bug 31056 we noticed that one function was
still needed but we copied it in the corresponding .tt

Now this JS file is no longer used and should be removed from the
codebase

Test plan:
  git grep basketgroup.js
must not return anything

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-02-24 20:58:13 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 17:58:20 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-03-08 14:06:30 UTC 
Missing dependencies for 22.05.x, no backport.