Created attachment 146485 [details] [review] Bug 32941: Sys prefs side menu styling applying where not intended In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places. The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.
I don't see the differences, could you attach before/after screenshots?
Created attachment 146611 [details] [review] Bug 32941: Sys prefs side menu styling applying where not intended In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places. The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Before: https://snipboard.io/ZCiV6F.jpg After : https://snipboard.io/t13nle.jpg We are looking at the background color of the eHoldings sub menu items.
Created attachment 146982 [details] [review] Bug 32941: Sys prefs side menu styling applying where not intended In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places. The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.