Created attachment 146519 [details] [review] Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely.
Created attachment 146577 [details] [review] Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Found those ones: koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt: <p>The record id <em>[% RECORDID | html %]</em> doesn't match any existing record.</p> koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt: <p>The import id number <em>[% IMPORTID | html %]</em> doesn't match any existing record.</p> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt: <span>The authority id [% message.authid | html %] does not exist in the database.</span> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt: <p>A payment with the transaction id '[% message_value | html %]' has already been posted to an account.</p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt: <p>The transaction id '[% message_value | html %]' for this payment is invalid.</p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: ERROR: No record found for record id [% bad_biblionumber | html %]. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: ERROR: No record id specified.
Created attachment 147276 [details] [review] Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 147277 [details] [review] Bug 32945: (QA follow-up) Fix capitalization of id in even more places This fixes additional strings pointed out by QA.
Created attachment 148586 [details] [review] Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 148587 [details] [review] Bug 32945: (QA follow-up) Fix capitalization of id in even more places This fixes additional strings pointed out by QA. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x