Bug 32952 - Standardize action fieldsets in authorities, cataloging, and circulation
Summary: Standardize action fieldsets in authorities, cataloging, and circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32746
Blocks: 32744
  Show dependency treegraph
 
Reported: 2023-02-13 16:36 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:


Attachments
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation (6.74 KB, patch)
2023-02-13 16:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation (6.77 KB, patch)
2023-02-13 18:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation (6.87 KB, patch)
2023-02-14 11:11 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation (6.89 KB, patch)
2023-02-24 21:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-13 16:36:52 UTC
As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in authorities, cataloging, and circulation.
Comment 1 Owen Leonard 2023-02-13 16:49:10 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-13 18:37:18 UTC
Created attachment 146595 [details] [review]
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation

This patch updates some templates in authorities, cataloging, and
circulation so that fieldsets with the "action" class are placed outside
the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Authorities -> Authority search -> Merge
- Catalog -> Search -> Merge records
- Catalog -> Bibliographic record details -> Edit -> Attach item
- Circulation -> Check out to patron -> Batch check out
- Circulation -> Overdues -> Sidebar filter
- Circulation -> Holds to pull -> Sidebar filter
Comment 3 Matt Blenkinsop 2023-02-14 11:11:33 UTC
Created attachment 146612 [details] [review]
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation

This patch updates some templates in authorities, cataloging, and
circulation so that fieldsets with the "action" class are placed outside
the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Authorities -> Authority search -> Merge
- Catalog -> Search -> Merge records
- Catalog -> Bibliographic record details -> Edit -> Attach item
- Circulation -> Check out to patron -> Batch check out
- Circulation -> Overdues -> Sidebar filter
- Circulation -> Holds to pull -> Sidebar filter

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Katrin Fischer 2023-02-24 21:17:24 UTC
Created attachment 147406 [details] [review]
Bug 32952: Standardize action fieldsets in authorities, cataloging, and circulation

This patch updates some templates in authorities, cataloging, and
circulation so that fieldsets with the "action" class are placed outside
the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Authorities -> Authority search -> Merge
- Catalog -> Search -> Merge records
- Catalog -> Bibliographic record details -> Edit -> Attach item
- Circulation -> Check out to patron -> Batch check out
- Circulation -> Overdues -> Sidebar filter
- Circulation -> Holds to pull -> Sidebar filter

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-03-10 15:03:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-13 11:12:36 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-04-14 16:40:52 UTC
Enhancement will not be backported to 22.05.x