As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools
Created attachment 146591 [details] [review] Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms)
Created attachment 146613 [details] [review] Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 147407 [details] [review] Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 148515 [details] [review] Bug 32954: Standardize action fieldsets in rotating collections, suggestions, tools As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers a few templates in rotating collections, suggestions, and tools. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Tools -> Rotating collections. Create a collection if necessary, then click "Action" -> "Manage items." Check the form on the manage items page. - Suggestions -> Sidebar filter. Check that different sets of filters expand and collapse correctly. - Tools -> Batch item modification (initial form) - Tools -> Inventory (initial form) - Cataloging -> Stage records for import (initial form) - Tools -> Upload (upload and search forms) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x