As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in lables, patrons, offline circulation, patron cards, and point of sale.
Created attachment 146596 [details] [review] Bug 32955: Standardize structure around action fieldsets in various templates This patch updates various templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Cataloging -> Quick spine label creator - Patrons -> Patron details -> Files - Patrons -> Patron details -> Housebound - Circulation -> Upload offline circulation file - Tools -> Patron card creator -> Manage -> Images - Point of sale -> Transaction history -> "Older transactions" form
Created attachment 147270 [details] [review] Bug 32955: Standardize structure around action fieldsets in various templates This patch updates various templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Cataloging -> Quick spine label creator - Patrons -> Patron details -> Files - Patrons -> Patron details -> Housebound - Circulation -> Upload offline circulation file - Tools -> Patron card creator -> Manage -> Images - Point of sale -> Transaction history -> "Older transactions" form
Created attachment 148915 [details] [review] Bug 32955: Standardize structure around action fieldsets in various templates This patch updates various templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Cataloging -> Quick spine label creator - Patrons -> Patron details -> Files - Patrons -> Patron details -> Housebound - Circulation -> Upload offline circulation file - Tools -> Patron card creator -> Manage -> Images - Point of sale -> Transaction history -> "Older transactions" form Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Created attachment 149351 [details] [review] Bug 32955: Standardize structure around action fieldsets in various templates This patch updates various templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Cataloging -> Quick spine label creator - Patrons -> Patron details -> Files - Patrons -> Patron details -> Housebound - Circulation -> Upload offline circulation file - Tools -> Patron card creator -> Manage -> Images - Point of sale -> Transaction history -> "Older transactions" form Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing 22.05.x dependencies. No backport.