The recalls table column names were changed before they were upstreamed but this change wasn't carried over to the notices.
Created attachment 146657 [details] [review] Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697
Created attachment 146699 [details] [review] Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697 Signed-off-by: David Nind <david@davidnind.com>
Created attachment 147339 [details] [review] Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.