Bug 32973 - Use template wrapper for breadcrumbs: about, main, and error page
Summary: Use template wrapper for breadcrumbs: about, main, and error page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-15 17:44 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page (3.41 KB, patch)
2023-02-17 17:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page (3.45 KB, patch)
2023-02-21 20:53 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page (3.51 KB, patch)
2023-02-24 21:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-15 17:44:04 UTC
To continue the process started by Bug 32507, this patch will update the staff interface main page template, about page template, and error page template to use the new WRAPPER construction to show breadcrumbs.
Comment 1 Owen Leonard 2023-02-17 17:25:45 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2023-02-21 20:53:09 UTC
Created attachment 147095 [details] [review]
Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page

This patch updates the staff interface home page, the about page, and
the error page template so that they use the new template WRAPPER for
breadcrumbs.

To test, apply the patch and view each page to confirm that the
breadcrumbs are correct:

- Staff interface home page
- About page
- Error page (the easiest example is a 404 error)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-02-24 21:38:00 UTC
Created attachment 147408 [details] [review]
Bug 32973: Use template wrapper for breadcrumbs: about, main, and error page

This patch updates the staff interface home page, the about page, and
the error page template so that they use the new template WRAPPER for
breadcrumbs.

To test, apply the patch and view each page to confirm that the
breadcrumbs are correct:

- Staff interface home page
- About page
- Error page (the easiest example is a 404 error)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-02-27 14:42:37 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-01 09:51:24 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-10 14:24:55 UTC
I think we'll leave these changes out of 22.05.x, there will likely be too many merge conflicts to want to deal with. No backport.