Bug 32982 - 'Add/Edit group' modals in library groups is missing it's primary button
Summary: 'Add/Edit group' modals in library groups is missing it's primary button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 31947
  Show dependency treegraph
 
Reported: 2023-02-16 13:42 UTC by Martin Renvoize
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19


Attachments
Bug 32982: Add primary button to libary group modals (1.94 KB, patch)
2023-02-16 15:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32982: Add primary button to libary group modals (2.00 KB, patch)
2023-02-22 11:00 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 32982: Add primary button to libary group modals (2.08 KB, patch)
2023-02-23 09:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-02-16 13:42:54 UTC
We don't have a primary, yellow, button in this modal yet.. we should.
Comment 1 Martin Renvoize 2023-02-16 15:26:35 UTC
Created attachment 146738 [details] [review]
Bug 32982: Add primary button to libary group modals

This patch updates the New and Edit group modals in the library groups
admin page to have a primary 'Save'/'Update' button and a default
'Cancel' button.
Comment 2 PTFS Europe Sandboxes 2023-02-22 11:00:01 UTC
Created attachment 147123 [details] [review]
Bug 32982: Add primary button to libary group modals

This patch updates the New and Edit group modals in the library groups
admin page to have a primary 'Save'/'Update' button and a default
'Cancel' button.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-02-22 11:06:31 UTC
Works as described, thanks for the patch.  Signing off.
Comment 4 Jonathan Druart 2023-02-23 09:21:40 UTC
Created attachment 147202 [details] [review]
Bug 32982: Add primary button to libary group modals

This patch updates the New and Edit group modals in the library groups
admin page to have a primary 'Save'/'Update' button and a default
'Cancel' button.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-24 20:06:56 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-02-28 16:50:44 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-03-08 13:53:12 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 8 Arthur Suzuki 2023-03-29 12:43:51 UTC
applied to 21.11 for 21.11.19
Comment 9 wainuiwitikapark 2023-04-27 05:32:25 UTC
Not backported to 21.05.x