Bug 32995 - Koha agent string not sent for OverDrive fulfillment requests
Summary: Koha agent string not sent for OverDrive fulfillment requests
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 29686
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-17 13:00 UTC by Nick Clemens (kidclamp)
Modified: 2024-07-04 20:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14
Circulation function:

Attachments
Bug 32995: Pass user agent string for OverDrive fulfillment (1.33 KB, patch)
2023-02-17 13:03 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 32995: Pass user agent string for OverDrive fulfillment (1.44 KB, patch)
2023-04-25 07:53 UTC, Magnus Enger 		Details | Diff | Splinter Review
Bug 32995: Pass user agent string for OverDrive fulfillment (1.53 KB, patch)
2023-05-12 09:14 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-02-17 13:00:48 UTC 
Bug 29686 added a call for the new OD fulfillment, but we neglected to pass our KOha user agent string
Comment 1 Nick Clemens (kidclamp) 2023-02-17 13:03:14 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2023-04-25 07:53:50 UTC 
Created attachment 150182 [details] [review]
Bug 32995: Pass user agent string for OverDrive fulfillment

This patch simply adds the string Koha/VERSION to the fulfillment
request

TO test:
1 - Have OverDrive credentials for testing
2 - Enable all the overdrive options in system preferences
3 - Sign in to opac with an overdrive user and verify you can checkout
  and download titles
4 - Sign off

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Not tested with OverDrive, but change looks harmless enough.
Comment 3 Marcel de Rooy 2023-05-12 09:14:02 UTC 
Created attachment 151124 [details] [review]
Bug 32995: Pass user agent string for OverDrive fulfillment

This patch simply adds the string Koha/VERSION to the fulfillment
request

TO test:
1 - Have OverDrive credentials for testing
2 - Enable all the overdrive options in system preferences
3 - Sign in to opac with an overdrive user and verify you can checkout
  and download titles
4 - Sign off

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Not tested with OverDrive, but change looks harmless enough.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-05-12 14:21:04 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-05-15 12:57:38 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-06-15 19:26:55 UTC 
Backported to 22.05.x for upcoming 22.05.14
Comment 7 Danyon Sewell 2023-07-20 04:17:21 UTC 
Not backporting to 21.11.x