Bug 33001 - Use template wrapper for breadcrumbs: Acquisitions part 2
Summary: Use template wrapper for breadcrumbs: Acquisitions part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-17 18:01 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 (17.12 KB, patch)
2023-02-18 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 (17.16 KB, patch)
2023-02-21 20:46 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33001: (follow-up) Add spans for translatability (7.65 KB, patch)
2023-02-24 11:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 (17.20 KB, patch)
2023-04-04 20:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 33001: (follow-up) Add spans for translatability (7.68 KB, patch)
2023-04-04 20:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 (17.31 KB, patch)
2023-04-09 11:22 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33001: (follow-up) Add spans for translatability (7.79 KB, patch)
2023-04-09 11:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-17 18:01:32 UTC
To continue the process started by Bug 32507, this patch will update some templates in acquisitions so that they use the new template wrapper for breadcrumbs.

- histsearch.tt
- invoice-files.tt
- invoice.tt
- invoices.tt
- lateorders.tt
- moddeliverydate.tt
- modordernotes.tt
- neworderempty.tt
- neworderempty_duplicate.tt
- newordersubscription.tt
Comment 1 Owen Leonard 2023-02-18 14:43:38 UTC
Created attachment 146917 [details] [review]
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  - Late orders,
    - moddeliverydate.tt
    - modordernotes.tt
    -- These two templates aren't linked to from anywhere, but
       you can navigate directly to:
       http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
       http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1

  - Order search, order search results
  - Invoice search,
    - Invoice details,
      - Invoice files
  - Vendor -> Basket -> Add to basket ->
    - From a new (empty) record
    - From existing orders (copy)
    - From a subscription
Comment 2 Lucas Gass 2023-02-21 20:46:24 UTC
Created attachment 147093 [details] [review]
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  - Late orders,
    - moddeliverydate.tt
    - modordernotes.tt
    -- These two templates aren't linked to from anywhere, but
       you can navigate directly to:
       http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
       http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1

  - Order search, order search results
  - Invoice search,
    - Invoice details,
      - Invoice files
  - Vendor -> Basket -> Add to basket ->
    - From a new (empty) record
    - From existing orders (copy)
    - From a subscription

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Owen Leonard 2023-02-24 11:53:42 UTC
Created attachment 147297 [details] [review]
Bug 33001: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>
Comment 4 David Nind 2023-04-04 20:18:22 UTC
Created attachment 149140 [details] [review]
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  - Late orders,
    - moddeliverydate.tt
    - modordernotes.tt
    -- These two templates aren't linked to from anywhere, but
       you can navigate directly to:
       http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
       http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1

  - Order search, order search results
  - Invoice search,
    - Invoice details,
      - Invoice files
  - Vendor -> Basket -> Add to basket ->
    - From a new (empty) record
    - From existing orders (copy)
    - From a subscription

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-04-04 20:18:24 UTC
Created attachment 149141 [details] [review]
Bug 33001: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-04-04 20:29:28 UTC
Testing notes (using KTD):

1. Setup for testing:
   1.1 Add a new serial subscription
   1.2 Enable AcqEnableFiles system preference (to add files to invoices)
   1.3 To test invoices: add an order to a basket, close basket, receive shipments, add a new invoice
   1.4 To test late orders: for a basket, add an order and then edit the 'Estimated delivery date' for the item so that it is before today - this will then show up under Acquisitions > Late orders.

2. View/tested pages mentioned in test plan - checked all breadcrumb links by opening the links in a new tab.

3. Translation spans - don't know enough about the translation process, but checked that there were span tags for the last item in the breadcrumb (also checked the patch to see which ones these were added to) -I hope that is sufficient.
Comment 7 Katrin Fischer 2023-04-09 11:22:58 UTC
Created attachment 149347 [details] [review]
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  - Late orders,
    - moddeliverydate.tt
    - modordernotes.tt
    -- These two templates aren't linked to from anywhere, but
       you can navigate directly to:
       http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
       http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1

  - Order search, order search results
  - Invoice search,
    - Invoice details,
      - Invoice files
  - Vendor -> Basket -> Add to basket ->
    - From a new (empty) record
    - From existing orders (copy)
    - From a subscription

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33005
Comment 8 Katrin Fischer 2023-04-09 11:23:01 UTC
Created attachment 149348 [details] [review]
Bug 33001: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=33005
Comment 9 Tomás Cohen Arazi 2023-04-12 14:44:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-04-16 20:37:27 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.