Bug 30599 added the ability to archive multiple purchase suggestions. The option is not there anymore...? To test: 1. Go to More > Suggestions 2. Click 'New purchase suggestion' 3. Enter a title 4. Click 'Submit your suggestion' --> Under the suggestions, there is a 'Delete selected' button/section. There should also be a 'Archive selected' button/section. The latter is not there anymore. See https://koha-community.org/manual/22.05/en/html/_images/suggestionmanagement.png for reference in 22.05 I did a git grep "Archive selected" and didn't find anything...
Git bisect: The button was accidentally removed by: Bug 23991: Move SearchSuggestion to Koha::Suggestions
Created attachment 146908 [details] [review] Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived'
Created attachment 146909 [details] [review] Bug 33003: Show the vendor type on vendor detail page When using an authorised value VENDOR_TYPE for the vendor type, we should show the AV description everywhere instead of the code. It already works on the vendor search, but not on the vendor detail page. With this patch it will also work there. To test: 1. Add at least one authorized value in VENDOR_TYPE 1.1. Go to Administration > Authorized values 1.2. Search for VENDOR_TYPE 1.3. Click 'Add' 1.4. Fill out the form - Authorized value: BOOK - Description: Print books 1.5. Click 'Save' 2. Add a new vendor 2.1. Go to Acquisitions 2.2. Click 'New vendor' 2.3. Fill out the form - Name: ABC Bookstore - Vendor type: Print books 2.4. Click 'Save' 3. Go to the vendor page 3.1. Click on the vendor name --> The value in "Type" is BOOK, it should be "Print books" 4. Apply patch 4.1. Repeat test, now it should show the description
Created attachment 146921 [details] [review] Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146959 [details] [review] Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Katrin! I really thought I was having eye trouble with this one... hehe
It was definitely a little odd - rebase issue I guess.
To RMs - please backport this to 22.11 since it's also broken there
Created attachment 147016 [details] [review] Bug 33002: Restore "Archive selected" for archiving multiple suggestions It looks like this button, added by bug 30599 was later accidentally removed again. This is giving it a comeback. To test: 1 - Apply patch 2 - Create some purchase suggestions 3 - Select several suggestions 4 - Click 'Archive selected' 5 - Suggestions are archived 6 - You can view archived suggestions by selecting 'Suggestion information'->'Include archived' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Sorry about that! Thanks for the patch, Katrin!
Pushed to master for 23.05. Nice work everyone, thanks!
(In reply to Jonathan Druart from comment #10) > Sorry about that! Thanks for the patch, Katrin! You are welcome. Doing a little detective work on the case of the "disappeared button" was fun :)
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Missing depedencies for 22.05.x, no backport.