Bug 33004 - Add VENDOR_TYPE to default authorised value categories
Summary: Add VENDOR_TYPE to default authorised value categories
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 31017
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-18 10:12 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33004: Add VENDOR_TYPE to default authorised value categories (2.10 KB, patch)
2023-02-18 11:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33004: Add VENDOR_TYPE to default authorised value categories (2.16 KB, patch)
2023-02-18 17:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33004: Add VENDOR_TYPE to default authorised value categories (2.23 KB, patch)
2023-02-23 09:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-18 10:12:14 UTC
On a fresh installation we are missing the VENDOR_TYPE authorised value category.
Comment 1 Katrin Fischer 2023-02-18 11:04:17 UTC
Created attachment 146912 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there
Comment 2 Owen Leonard 2023-02-18 17:46:34 UTC
Created attachment 146928 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Caroline Cyr La Rose 2023-02-20 15:20:32 UTC
To RMs - please backport to 22.11 since the vendor_type functionality was introduced in that version
Comment 4 Jonathan Druart 2023-02-23 09:36:39 UTC
Created attachment 147205 [details] [review]
Bug 33004: Add VENDOR_TYPE to default authorised value categories

To test:
* Go to administration > authorised values
* Verify that VENDOR_TYPE doesn't show in the list
* Apply patch
* Run database update
* Verify that VENDOR_TYPE does now appear and has a nice
  description (not added by this patch)
* Bonus: start over and run the web installer, VENDOR_TYPE
  should now be already there

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-27 16:07:16 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-03-01 16:51:35 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.