Bug 33006 - Use template wrapper for breadcrumbs: Administration part 1
Summary: Use template wrapper for breadcrumbs: Administration part 1
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks: 33696
  Show dependency treegraph
 
Reported: 2023-02-18 15:51 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 (33.12 KB, patch)
2023-02-18 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 (33.21 KB, patch)
2023-02-18 16:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 (33.25 KB, patch)
2023-02-21 20:37 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33006: (follow-up) Add spans for translatability (20.89 KB, patch)
2023-02-24 15:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33006: (follow-up) Add spans for translatability (20.95 KB, patch)
2023-03-31 18:16 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 (33.30 KB, patch)
2023-04-09 11:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33006: (follow-up) Add spans for translatability (21.00 KB, patch)
2023-04-09 11:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-18 15:51:33 UTC
To continue the process started by Bug 32507, this patch will update several templates in administration so that they use the new template wrapper for breadcrumbs.

- additional-fields.tt
- admin-home.tt
- adveditorshortcuts.tt
- aqbudgetperiods.tt
- aqbudgets.tt
- aqcontract.tt
- aqplan.tt
- audio_alerts.tt
- auth_subfields_structure.tt
- auth_tag_structure.tt
Comment 1 Owen Leonard 2023-02-18 16:22:04 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-18 16:31:37 UTC Comment hidden (obsolete)
Comment 3 Lucas Gass 2023-02-21 20:37:33 UTC
Created attachment 147092 [details] [review]
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

Note: The patch includes indentation changes, so ignore whitespace
when viewing the diff.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration
  -> Administration home page
     - Under "Additional parameters"
       -> Additional fields
          -> View, create, edit
       -> Advanced editor shortcuts
       -> Audio alerts
     - Under "Acquisition parameters"
       -> Budgets
          -> Add fund
          -> Close fund
          -> Budget details
             -> Planning
          -> Create, edit, duplicate
     - Under "Catalog"
       -> Authority types -> MARC structure
          -> New, edit, delete
          -> "Actions" -> Subfields
            -> Edit, delete
Acquisitions -> Vendor -> Contracts
  - View, edit, delete

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Owen Leonard 2023-02-24 15:02:22 UTC
Created attachment 147338 [details] [review]
Bug 33006: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

This patch also modifies some of the templates to simplify
the logic controlling how different elements of the breadcrumbs are
shown or not.

This patch also modifies another problematic set of strings in
auth_tag_structure.tt outside the breadcrumbs.
Comment 5 ByWater Sandboxes 2023-03-31 18:16:05 UTC
Created attachment 149053 [details] [review]
Bug 33006: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

This patch also modifies some of the templates to simplify
the logic controlling how different elements of the breadcrumbs are
shown or not.

This patch also modifies another problematic set of strings in
auth_tag_structure.tt outside the breadcrumbs.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 6 Andrew Auld 2023-03-31 18:16:50 UTC
Lovely!
Comment 7 Katrin Fischer 2023-04-09 11:18:10 UTC
Created attachment 149338 [details] [review]
Bug 33006: Use template wrapper for breadcrumbs: Administration part 1

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

Note: The patch includes indentation changes, so ignore whitespace
when viewing the diff.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration
  -> Administration home page
     - Under "Additional parameters"
       -> Additional fields
          -> View, create, edit
       -> Advanced editor shortcuts
       -> Audio alerts
     - Under "Acquisition parameters"
       -> Budgets
          -> Add fund
          -> Close fund
          -> Budget details
             -> Planning
          -> Create, edit, duplicate
     - Under "Catalog"
       -> Authority types -> MARC structure
          -> New, edit, delete
          -> "Actions" -> Subfields
            -> Edit, delete
Acquisitions -> Vendor -> Contracts
  - View, edit, delete

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-04-09 11:18:13 UTC
Created attachment 149339 [details] [review]
Bug 33006: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

This patch also modifies some of the templates to simplify
the logic controlling how different elements of the breadcrumbs are
shown or not.

This patch also modifies another problematic set of strings in
auth_tag_structure.tt outside the breadcrumbs.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-04-12 14:22:37 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-04-16 20:45:56 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.