Bug 33011 - Capitalization: Show in Staff interface?
Summary: Capitalization: Show in Staff interface?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 17170
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-20 09:43 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33011: Fix capitalization for "Show in Staff interface?" (1.72 KB, patch)
2023-02-20 21:05 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33011: Fix capitalization for "Show in Staff interface?" (1.80 KB, patch)
2023-02-21 09:36 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33011: Fix capitalization for "Show in Staff interface?" (1.86 KB, patch)
2023-02-23 14:39 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-20 09:43:43 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt

64 <label for="filter_edit_staff_client">Show in Staff interface?</label>

Shoudl be "staff interface"
Comment 1 Katrin Fischer 2023-02-20 21:05:45 UTC
Created attachment 146975 [details] [review]
Bug 33011: Fix capitalization for "Show in Staff interface?"

This fixes another previously missed occurence.

To test:
* Activate SavedSearchFilters system preference
* Search anything and save your search as a filter from
  the staff interface results page
* Go to Administration > search filters
* Click 'Edit search' for your saved filter
* Confirm you are taken to advanced search page
* On top of the page, you'll see: Show in Staff interface?
* Apply patch
* Verify the string was corrected
Comment 2 Matt Blenkinsop 2023-02-21 09:36:43 UTC
Created attachment 147017 [details] [review]
Bug 33011: Fix capitalization for "Show in Staff interface?"

This fixes another previously missed occurence.

To test:
* Activate SavedSearchFilters system preference
* Search anything and save your search as a filter from
  the staff interface results page
* Go to Administration > search filters
* Click 'Edit search' for your saved filter
* Confirm you are taken to advanced search page
* On top of the page, you'll see: Show in Staff interface?
* Apply patch
* Verify the string was corrected

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Jonathan Druart 2023-02-23 14:39:40 UTC
Created attachment 147238 [details] [review]
Bug 33011: Fix capitalization for "Show in Staff interface?"

This fixes another previously missed occurence.

To test:
* Activate SavedSearchFilters system preference
* Search anything and save your search as a filter from
  the staff interface results page
* Go to Administration > search filters
* Click 'Edit search' for your saved filter
* Confirm you are taken to advanced search page
* On top of the page, you'll see: Show in Staff interface?
* Apply patch
* Verify the string was corrected

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-02-24 19:57:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 16:46:16 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-08 13:33:08 UTC
Missing dependency for 22.05.x, no backport.