Bug 33014 - Add link to serial advanced search
Summary: Add link to serial advanced search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: regression
: 33067 (view as bug list)
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-20 17:25 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33014: Add link to advanced serial search in search bar (1.61 KB, patch)
2023-02-20 20:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33014: Improve serial searches (19.17 KB, patch)
2023-02-23 17:28 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33014: Improve serial searches (19.24 KB, patch)
2023-02-23 21:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33014: Improve serial searches (19.28 KB, patch)
2023-02-23 22:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33014: (QA follow-up) Move filters before navigation in sidebar (1.64 KB, patch)
2023-02-23 22:10 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-02-20 17:25:58 UTC
It seems the staff interface redesign removed the link to the serial advanced search (it used to be next to the search button in the search bar at the top see https://koha-community.org/manual/22.05/en/html/_images/subsearch.png for reference).

We should add it back, since there is no other way to access serials-search.pl than to do a search/empty search or the former link. (Maybe in the menu on the left since the new search bar doesn't really allow for such links... Or as the content of serials-home.pl)
Comment 1 Katrin Fischer 2023-02-20 20:29:49 UTC
Created attachment 146972 [details] [review]
Bug 33014: Add link to advanced serial search in search bar

This adds the link as an option to expand at the end of the field,
modeled after the way we do it in the acq module.
Comment 2 Katrin Fischer 2023-02-20 20:34:12 UTC
Not sure about this one. In the acq module we have more search options in the expanding options and the link at the bottom. Here we only have the link.

I looked for an example where we have a link (not a tab) in the navigation bar, but I don't think there is an example with the new design. Leaving the patch as NSO for gathering some ideas and opinions.

Owen, maybe you got an idea/opinion on this one?
Comment 3 Caroline Cyr La Rose 2023-02-21 16:57:30 UTC
I agree that it's not an easy one...

-  maybe add a couple of fields to make it look like the search options in acquisitions? not sure which are most used... title and ISSN are already there... maybe vendor?

-  the main serial page is empty, so we could use it for the advanced search form

-  we could add a search option in the left menu

I'm sure Owen will have a brilliant idea :)
Comment 4 Lucas Gass 2023-02-22 14:32:35 UTC
(In reply to Caroline Cyr La Rose from comment #3)
> I agree that it's not an easy one...
> 
> -  maybe add a couple of fields to make it look like the search options in
> acquisitions? not sure which are most used... title and ISSN are already
> there... maybe vendor?
> 
> -  the main serial page is empty, so we could use it for the advanced search
> form
> 
> -  we could add a search option in the left menu
> 
> I'm sure Owen will have a brilliant idea :)

Caroline, 

Maybe we could implement all 3 of your ideas?
Comment 5 Lucas Gass 2023-02-23 17:28:31 UTC
Created attachment 147261 [details] [review]
Bug 33014: Improve serial searches

This patch adds a new include for the serials 'advanced search' and uses that include on the serials home and serials search pages. It also adds some extra options ( Call number, publisher, vendor ) to the search included in the header.

To test:
1. Apply patch
2. Go to the serials module and notice the main page now has an 'advanced search' form. Make sure it works.
3. After doing a search you'll be taken to serials-search.pl. Make sure the search forms in the side bar and in the header look good and work right.
Comment 6 Owen Leonard 2023-02-23 21:07:38 UTC
Created attachment 147269 [details] [review]
Bug 33014: Improve serial searches

This patch adds a new include for the serials 'advanced search' and
uses that include on the serials home and serials search pages. It also
adds some extra options ( Call number, publisher, vendor ) to the
search included in the header.

To test:
1. Apply patch
2. Go to the serials module and notice the main page now has an
   'advanced search' form. Make sure it works.
3. After doing a search you'll be taken to serials-search.pl. Make sure
   the search forms in the side bar and in the header look good and work
   right.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2023-02-23 22:09:59 UTC
Created attachment 147272 [details] [review]
Bug 33014: Improve serial searches

This patch adds a new include for the serials 'advanced search' and
uses that include on the serials home and serials search pages. It also
adds some extra options ( Call number, publisher, vendor ) to the
search included in the header.

To test:
1. Apply patch
2. Go to the serials module and notice the main page now has an
   'advanced search' form. Make sure it works.
3. After doing a search you'll be taken to serials-search.pl. Make sure
   the search forms in the side bar and in the header look good and work
   right.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-02-23 22:10:02 UTC
Created attachment 147273 [details] [review]
Bug 33014: (QA follow-up) Move filters before navigation in sidebar

This follows the pattern we have on other pages like suggestions,
tags and invoices by putting the filters on top of the navigation
in the sidebar on the left.

To test:
* Search subscriptions
* Verify that on the left it's navigation - search options
* Apply patch
* Verify it's now: search options - navigation

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-02-24 20:07:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Katrin Fischer 2023-02-27 22:27:45 UTC
*** Bug 33067 has been marked as a duplicate of this bug. ***
Comment 11 Matt Blenkinsop 2023-02-28 16:54:40 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 12 Lucas Gass 2023-03-08 13:55:40 UTC
Missing dependencies for 22.05.x, no backport.