Bug 33015 - 'Cancel' link still points to tools home when it should be cataloguing home on some pages
Summary: 'Cancel' link still points to tools home when it should be cataloguing home o...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 31162
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-20 22:00 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33015: Fix some 'Cancel' links to point to cataloging start page (3.43 KB, patch)
2023-02-20 22:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33015: Fix some 'Cancel' links to point to cataloging start page (3.48 KB, patch)
2023-02-21 20:56 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33015: Fix some 'Cancel' links to point to cataloging start page (3.79 KB, patch)
2023-02-23 09:29 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-20 22:00:14 UTC
To test:
* Create a MARC modification template
* Go to Record batch modification page
* Click on cancel - it goes to tools home, but this is now a cataloging thing
Comment 1 Katrin Fischer 2023-02-20 22:16:45 UTC
Created attachment 146980 [details] [review]
Bug 33015: Fix some 'Cancel' links to point to cataloging start page

Some 'cancel' links of tools moved to the cataloguing module still
pointed to the tools start page. This adds some more consistency.

To test:
* Go to cataloguing
  * Batch item editing
  * Batch record deletion
  * Batch record modification (create a MARC modification template first)
* Verify the 'cancel' link on each page points to tools
* Apply patch: cancelling should not take you to the cataloging start page
Comment 2 Lucas Gass 2023-02-21 20:56:25 UTC
Created attachment 147096 [details] [review]
Bug 33015: Fix some 'Cancel' links to point to cataloging start page

Some 'cancel' links of tools moved to the cataloguing module still
pointed to the tools start page. This adds some more consistency.

To test:
* Go to cataloguing
  * Batch item editing
  * Batch record deletion
  * Batch record modification (create a MARC modification template first)
* Verify the 'cancel' link on each page points to tools
* Apply patch: cancelling should not take you to the cataloging start page

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-02-23 09:29:31 UTC
Created attachment 147204 [details] [review]
Bug 33015: Fix some 'Cancel' links to point to cataloging start page

Some 'cancel' links of tools moved to the cataloguing module still
pointed to the tools start page. This adds some more consistency.

To test:
* Go to cataloguing
  * Batch item editing
  * Batch record deletion
  * Batch record modification (create a MARC modification template first)
* Verify the 'cancel' link on each page points to tools
* Apply patch: cancelling should not take you to the cataloging start page

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: indentation + fix typo
-        <a class="cancel" href="/cgi-bin/koha/catalouging/cataloging-home.pl">Cancel</a>
+        <a class="cancel" href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cancel</a>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-02-27 14:42:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-01 09:51:27 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-10 14:19:21 UTC
Missing dependencies for 22.05.11, no backport.