Bug 33016 - MARC diff view still shows tools instead of cataloging in title and breadcrumbs
Summary: MARC diff view still shows tools instead of cataloging in title and breadcrumbs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 31162
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-20 22:21 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging (1.88 KB, patch)
2023-02-20 22:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging (1.93 KB, patch)
2023-02-21 20:29 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging (2.00 KB, patch)
2023-02-23 09:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-20 22:21:26 UTC

    
Comment 1 Katrin Fischer 2023-02-20 22:25:46 UTC
Created attachment 146981 [details] [review]
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging

Some remaining to dos of us moving the staged import tools from
tools to cataloging.

To test:
* Export a record from your Koha catalog
* Import it using the staged MARC import tool, matching on biblionumber
  (the diff view is only visible if the record matched an existing one)
* View the staged records
* Click on the 'Diff' link
* Verify that the page title and breadcrumbs still read 'Tools'
* Apply patch
* Not these should read 'Cataloging'
Comment 2 Lucas Gass 2023-02-21 20:29:36 UTC
Created attachment 147091 [details] [review]
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging

Some remaining to dos of us moving the staged import tools from
tools to cataloging.

To test:
* Export a record from your Koha catalog
* Import it using the staged MARC import tool, matching on biblionumber
  (the diff view is only visible if the record matched an existing one)
* View the staged records
* Click on the 'Diff' link
* Verify that the page title and breadcrumbs still read 'Tools'
* Apply patch
* Not these should read 'Cataloging'

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-02-23 09:26:29 UTC
Created attachment 147203 [details] [review]
Bug 33016: Change breadcrumbs and page title on MARC diff view to cataloging

Some remaining to dos of us moving the staged import tools from
tools to cataloging.

To test:
* Export a record from your Koha catalog
* Import it using the staged MARC import tool, matching on biblionumber
  (the diff view is only visible if the record matched an existing one)
* View the staged records
* Click on the 'Diff' link
* Verify that the page title and breadcrumbs still read 'Tools'
* Apply patch
* Not these should read 'Cataloging'

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-02-24 19:57:07 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-28 16:40:44 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-03-08 13:26:45 UTC
Not needed in 22.05.x, no backport.