Bug 33041 - Use process_tt in C4::Serial::NewIssue
Summary: Use process_tt in C4::Serial::NewIssue
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33030 33039
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-22 16:46 UTC by Kyle M Hall
Modified: 2023-12-28 20:46 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33041: Use process_tt in C4::Serial::NewIssue (4.14 KB, patch)
2023-02-22 16:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33041: Use process_tt in C4::Serial::NewIssue (4.18 KB, patch)
2023-05-02 11:12 UTC, David Nind
Details | Diff | Splinter Review
Bug 33041: Use process_tt in C4::Serial::NewIssue (4.29 KB, patch)
2023-07-07 09:53 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-02-22 16:46:50 UTC
Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue
Comment 1 Kyle M Hall 2023-02-22 16:48:23 UTC
Created attachment 147175 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t
Comment 2 David Nind 2023-05-02 11:12:08 UTC
Created attachment 150515 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-02 11:13:27 UTC
Testing notes (using KTD):

1. After applying the patch and dependencies, run updatedatabase (for 33039).
Comment 4 Marcel de Rooy 2023-07-07 09:53:56 UTC
Created attachment 153144 [details] [review]
Bug 33041: Use process_tt in C4::Serial::NewIssue

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in C4::Serial::NewIssue

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Items.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-07-18 17:08:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!