Bug 33043 - Use process_tt in SIP modules
Summary: Use process_tt in SIP modules
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33030
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-22 16:59 UTC by Kyle M Hall
Modified: 2023-07-19 08:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33043: Use process_tt in SIP modules (3.38 KB, patch)
2023-02-22 17:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33043: Use process_tt in SIP modules (3.72 KB, patch)
2023-02-22 18:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33043: Use process_tt in SIP modules (3.71 KB, patch)
2023-05-02 12:12 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33043: Use process_tt in SIP modules (3.76 KB, patch)
2023-05-02 16:20 UTC, David Nind
Details | Diff | Splinter Review
Bug 33043: Use process_tt in SIP modules (3.86 KB, patch)
2023-07-14 06:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-02-22 16:59:41 UTC
Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in the various parts of the SIP server code where we are currently using Template::process directly.
Comment 1 Kyle M Hall 2023-02-22 17:01:47 UTC
Created attachment 147176 [details] [review]
Bug 33043: Use process_tt in SIP modules

Bug 33030 implements a new helper subroutine to standardize processing of
Template Toolkit syntax outside slips and notices. We should use this
subroutine in the various parts of the SIP server code where we are
currently using Template::process directly.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP
Comment 2 Kyle M Hall 2023-02-22 18:26:41 UTC
Created attachment 147180 [details] [review]
Bug 33043: Use process_tt in SIP modules

Bug 33030 implements a new helper subroutine to standardize processing of
Template Toolkit syntax outside slips and notices. We should use this
subroutine in the various parts of the SIP server code where we are
currently using Template::process directly.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP
Comment 3 David Nind 2023-05-02 01:58:18 UTC
The patch no longer applies 8-(..

Applying: Bug 33043: Use process_tt in SIP modules
Using index info to reconstruct a base tree...
M       C4/SIP/ILS/Patron.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/SIP/ILS/Patron.pm
CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33043: Use process_tt in SIP modules
Comment 4 Kyle M Hall 2023-05-02 12:12:15 UTC
Created attachment 150516 [details] [review]
Bug 33043: Use process_tt in SIP modules

Bug 33030 implements a new helper subroutine to standardize processing of
Template Toolkit syntax outside slips and notices. We should use this
subroutine in the various parts of the SIP server code where we are
currently using Template::process directly.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP
Comment 5 David Nind 2023-05-02 16:20:45 UTC
Created attachment 150522 [details] [review]
Bug 33043: Use process_tt in SIP modules

Bug 33030 implements a new helper subroutine to standardize processing of
Template Toolkit syntax outside slips and notices. We should use this
subroutine in the various parts of the SIP server code where we are
currently using Template::process directly.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-05-02 16:22:04 UTC
Testing notes (using KTD):

1. After applying the patch and dependencies, run updatedatabase (for 33039).
Comment 7 Marcel de Rooy 2023-07-14 06:57:22 UTC
Created attachment 153430 [details] [review]
Bug 33043: Use process_tt in SIP modules

Bug 33030 implements a new helper subroutine to standardize processing of
Template Toolkit syntax outside slips and notices. We should use this
subroutine in the various parts of the SIP server code where we are
currently using Template::process directly.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2023-07-14 06:57:46 UTC
 OK     C4/SIP/ILS/Item.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     C4/SIP/ILS/Patron.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid
Comment 9 Tomás Cohen Arazi 2023-07-18 15:47:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-07-19 08:22:06 UTC
Enhancement not required in 23.05.x