Bug 33045 - Use process_tt in C4::Record::marcrecord2csv
Summary: Use process_tt in C4::Record::marcrecord2csv
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33030
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-22 18:16 UTC by Kyle M Hall
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33045: Use process_tt in C4::Record::marcrecord2csv (1.49 KB, patch)
2023-02-22 19:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33045: Use process_tt in C4::Record::marcrecord2csv (1.54 KB, patch)
2023-05-02 01:52 UTC, David Nind
Details | Diff | Splinter Review
Bug 33045: Use process_tt in C4::Record::marcrecord2csv (1.63 KB, patch)
2023-09-15 09:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33045: Fix shebang of marcrecord2csv.t (860 bytes, patch)
2023-09-15 09:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-02-22 18:16:15 UTC
Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.
Comment 1 Kyle M Hall 2023-02-22 19:49:04 UTC
Created attachment 147181 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t
Comment 2 David Nind 2023-05-02 01:52:21 UTC
Created attachment 150493 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-09-15 09:29:02 UTC
Created attachment 155652 [details] [review]
Bug 33045: Use process_tt in C4::Record::marcrecord2csv

Bug 33030 implements a new helper subroutine to standardize processing of Template Toolkit syntax outside slips and notices. We should use this subroutine in marcrecord2csv.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Record/marcrecord2csv.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2023-09-15 09:29:05 UTC
Created attachment 155653 [details] [review]
Bug 33045: Fix shebang of marcrecord2csv.t

Resolves:
bash: t/db_dependent/Record/marcrecord2csv.t: /usr/bin/perl;: bad interpreter: No such file or directory

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-09-15 14:58:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-18 08:31:49 UTC
Depends on Bug 33030 not in 23.05.x