Steps to reproduce: 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" is empty.
Created attachment 147186 [details] [review] Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref
Created attachment 147227 [details] [review] Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described. Thanks! The only thing I noticed was that it isn't decoded, so on mouseover it shows the email address as %40 instead of @. I'm not convinced it matters as all of the functionality is there. Clicking on the link launches a new email to the correct recipient. If you don't use a default mail client, copying/pasting the link also works.
Created attachment 147401 [details] [review] Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11 for 21.11.19
Not backported to 21.05.x