We still have "Staff Collection" and "Restricted Access" in the sample values for authorised values that don't follow capitalization rules.
Created attachment 147271 [details] [review] Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories
Created attachment 148110 [details] [review] Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com>
Testing notes: 1. A reset_all updated all the updated values after applying the patch. 2. I also tested by using the web installer (see https://gitlab.com/-/snippets/1893788#user-content-start-the-web-installer)
Created attachment 148239 [details] [review] Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment on attachment 148239 [details] [review] Bug 33059: Fix capitalizatoin of AV sample category descriptions Review of attachment 148239 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/en/mandatory/auth_values.yml @@ +4045,5 @@ > > - category: "qualif" > authorised_value: "110" > + lib: "Binder an agent who binds an item." > + lib_opac: "Binder an agent who binds an item." I'm not 100% sure about this one.. it doesn't read right to me. "Binder, the agent who binds an item." perhaps?
I find it interesting that Binder is the only relator term with an explanation of what it is... Are we afraid we're going to think that it is like a 3-ring binder type thing? The context of the authorised value list should make it obvious. I found the list in English here: https://cdn.ifla.org/wp-content/uploads/U_B_AppB_update2021_ONLINE_FINAL-1.pdf The explanation is really "An agent who binds an item." Personally, I would either remove it to match all the other relator terms, or put the explanation in parentheses, but keep the "An agent".
Of course, I'm speaking without *any* UNIMARC experience... I can try to contact the French list and have one of them comment on this.
I also stumbled on that one, but maybe we could solve separately? This one was only about cosmetics. :)
(In reply to Katrin Fischer from comment #8) > I also stumbled on that one, but maybe we could solve separately? This one > was only about cosmetics. :) Good idea
Created attachment 148333 [details] [review] Bug 33059: Fix capitalizatoin of AV sample category descriptions * Fixes capitalization * Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book) * Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook) To test: * This is a little difficult to test. What you'd need to do: * Apply the patch * Drop your database, recreate it, run the web installer * Make sure to select the optional AV along with the mandatory to install * Log into Koha after finishing the installer and go to administration > authorised values * Review the existing sample values for incorrect capitalization in the different categories Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x