Bug 33060 - Fix yes/no setting to 1/0 in system preference YAML files
Summary: Fix yes/no setting to 1/0 in system preference YAML files
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 20058
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-23 22:15 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files (2.61 KB, patch)
2023-02-23 22:22 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files (2.66 KB, patch)
2023-02-27 12:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files (1.94 KB, patch)
2023-03-15 16:22 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-23 22:15:50 UTC

    
Comment 1 Katrin Fischer 2023-02-23 22:22:34 UTC
Created attachment 147274 [details] [review]
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

Boolean system preferences need to use 1 and 0 for true and false,
not yes and no now. This fixes a few occurences that have
been added in the last release:

* EnableItemGroups
* EnableItemGroupHolds
* ArticleRequestsOpacHostRedirection
* UseLocationAsAQInSIP

To test:
* Make sure these preferences save to the db as 0/1 as expected.
Comment 2 Owen Leonard 2023-02-27 12:02:38 UTC
Created attachment 147432 [details] [review]
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

Boolean system preferences need to use 1 and 0 for true and false,
not yes and no now. This fixes a few occurences that have
been added in the last release:

* EnableItemGroups
* EnableItemGroupHolds
* ArticleRequestsOpacHostRedirection
* UseLocationAsAQInSIP

To test:
* Make sure these preferences save to the db as 0/1 as expected.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2023-03-15 16:22:03 UTC
Created attachment 148230 [details] [review]
Bug 33060: Fix yes/no setting to 1/0 in system preference YAML files

Boolean system preferences need to use 1 and 0 for true and false,
not yes and no now. This fixes a few occurences that have
been added in the last release:

* EnableItemGroups
* EnableItemGroupHolds
* ArticleRequestsOpacHostRedirection
* UseLocationAsAQInSIP

To test:
* Make sure these preferences save to the db as 0/1 as expected.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-03-15 16:23:46 UTC
Does as describe so Passing QA.

Does raise a minor questiont though.. we have 'default:yes' a few times in authorities.pref where they relate to 0|1 preferences.. should those now be 'default:1' ?
Comment 5 Tomás Cohen Arazi 2023-03-20 12:43:12 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-21 16:41:51 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-04-24 16:51:33 UTC
Doesn't apply cleanly to 22.05.x, no backport.