Bug 33064 - Add a search option for licenses to top search bar
Summary: Add a search option for licenses to top search bar
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matt Blenkinsop
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-24 14:40 UTC by Katrin Fischer
Modified: 2023-06-15 19:45 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
**Sponsored by** *PTFS Europe*
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33064: Add a licenses option to the searchbar (3.55 KB, patch)
2023-04-18 13:18 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33064: Update cypress tests (1.93 KB, patch)
2023-04-18 13:19 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33064: Add a licenses option to the searchbar (3.58 KB, patch)
2023-04-18 16:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33064: Update cypress tests (1.97 KB, patch)
2023-04-18 16:15 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33064: Add a licenses option to the searchbar (3.65 KB, patch)
2023-04-27 11:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33064: Update cypress tests (1.57 KB, patch)
2023-04-27 11:42 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-24 14:40:27 UTC
With bug 32728 we now switch to the correct search option when switching between different pages in the ERM module.

For licenses we keep "Agreements", because there is no licenses search (yet). It would be nice if one could be added for consistency and for usability.
Comment 1 Matt Blenkinsop 2023-04-18 13:18:26 UTC
Created attachment 149803 [details] [review]
Bug 33064: Add a licenses option to the searchbar

This patch adds a licenses option to the top searchbar

Test plan:
1) Apply patch
2) run yarn build
3) Navigate to the ERM module
4) Observe that the top search bar should have an option for licenses
5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option
Comment 2 Matt Blenkinsop 2023-04-18 13:19:44 UTC
Created attachment 149805 [details] [review]
Bug 33064: Update cypress tests

This patch amends Searchbar_spec.ts to account for the new licenses option

Test plan:
1) Run yarn cypress open
2) Select the Searchbar_spec.ts test
3) The test should pass
Comment 3 Lucas Gass 2023-04-18 16:15:21 UTC
Created attachment 149821 [details] [review]
Bug 33064: Add a licenses option to the searchbar

This patch adds a licenses option to the top searchbar

Test plan:
1) Apply patch
2) run yarn build
3) Navigate to the ERM module
4) Observe that the top search bar should have an option for licenses
5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass 2023-04-18 16:15:23 UTC
Created attachment 149822 [details] [review]
Bug 33064: Update cypress tests

This patch amends Searchbar_spec.ts to account for the new licenses option

Test plan:
1) Run yarn cypress open
2) Select the Searchbar_spec.ts test
3) The test should pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Martin Renvoize 2023-04-27 11:42:36 UTC
Created attachment 150290 [details] [review]
Bug 33064: Add a licenses option to the searchbar

This patch adds a licenses option to the top searchbar

Test plan:
1) Apply patch
2) run yarn build
3) Navigate to the ERM module
4) Observe that the top search bar should have an option for licenses
5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-04-27 11:42:39 UTC
Created attachment 150291 [details] [review]
Bug 33064: Update cypress tests

This patch amends Searchbar_spec.ts to account for the new licenses option

Test plan:
1) Run yarn cypress open
2) Select the Searchbar_spec.ts test
3) The test should pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2023-04-27 11:42:59 UTC
All working as described, QA scripts happy.

Passing QA
Comment 8 Tomás Cohen Arazi 2023-05-10 18:28:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-05-15 14:15:46 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 10 Lucas Gass 2023-06-15 19:45:11 UTC
Missing dependencies for 22.05.x, no backport