With bug 32728 we now switch to the correct search option when switching between different pages in the ERM module. For licenses we keep "Agreements", because there is no licenses search (yet). It would be nice if one could be added for consistency and for usability.
Created attachment 149803 [details] [review] Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option
Created attachment 149805 [details] [review] Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass
Created attachment 149821 [details] [review] Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 149822 [details] [review] Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 150290 [details] [review] Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150291 [details] [review] Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working as described, QA scripts happy. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport