When trying to download the list contents in MARC in the OPAC, I get the following error: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93
The same records download ok from the cart.
I have the same error and after check the code, i see maybe the correction. In line 93, there is an extra "->" after "record" in my opinion. When I replace the line "my $record = $biblio->metadata->record->(" with "my $record = $biblio->metadata->record(", the download works.
Created attachment 150619 [details] [review] Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com>
(In reply to Kévin AYRAULT from comment #2) > I have the same error and after check the code, i see maybe the correction. > In line 93, there is an extra "->" after "record" in my opinion. > When I replace the line "my $record = $biblio->metadata->record->(" with "my > $record = $biblio->metadata->record(", the download works. Thank you! This was the problem, with the change the error is gone :)
Created attachment 150631 [details] [review] Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after.
Thx Magnus :)
Created attachment 150807 [details] [review] Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com>
Created attachment 150835 [details] [review] Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Missing dependencies for 22.05.x, no backport.