Bug 33071 - Show tooltip when hovering on home icon in staff interface breadcrumbs
Summary: Show tooltip when hovering on home icon in staff interface breadcrumbs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-24 21:37 UTC by Katrin Fischer
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Circulation function:

Attachments
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs (1.40 KB, patch)
2023-03-01 19:31 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs (1.45 KB, patch)
2023-03-02 13:17 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs (1.51 KB, patch)
2023-03-04 12:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-02-24 21:37:18 UTC 
As we only display the house icon now with no text, it might be nice to have a tooltip on the icon appear when hovering on it.
Comment 1 Owen Leonard 2023-03-01 19:31:27 UTC 
Created attachment 147578 [details] [review]
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs

This patch modifies the breadcrumbs WRAPPER in html_helpers.inc so that
the default "Home" link has a title attribute set to "Home."

To test, apply the patch and view any page which has been updated to use
the breadcrumbs WRAPPER. For example, cities administration, the
staff interface home page, the about page.

Hover your mouse over the house icon in the breadcrumb navigation and
you should see a "Home" tooltip.
Comment 2 Lucas Gass (lukeg) 2023-03-02 13:17:06 UTC 
Created attachment 147613 [details] [review]
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs

This patch modifies the breadcrumbs WRAPPER in html_helpers.inc so that
the default "Home" link has a title attribute set to "Home."

To test, apply the patch and view any page which has been updated to use
the breadcrumbs WRAPPER. For example, cities administration, the
staff interface home page, the about page.

Hover your mouse over the house icon in the breadcrumb navigation and
you should see a "Home" tooltip.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-03-04 12:55:32 UTC 
Created attachment 147750 [details] [review]
Bug 33071: Show tooltip when hovering on home icon in staff interface breadcrumbs

This patch modifies the breadcrumbs WRAPPER in html_helpers.inc so that
the default "Home" link has a title attribute set to "Home."

To test, apply the patch and view any page which has been updated to use
the breadcrumbs WRAPPER. For example, cities administration, the
staff interface home page, the about page.

Hover your mouse over the house icon in the breadcrumb navigation and
you should see a "Home" tooltip.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-06 17:47:19 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-09 09:41:06 UTC 
Enhancement - not backporting to 22.11.x. 
Setting to Needs documenting. 
Nice work everyone!
Comment 6 Aude Charillon 2023-11-03 15:17:19 UTC 
No update to Manual needed. Setting to Resolved.