Bug 33075 - Add ability to mark an item as floating
Summary: Add ability to mark an item as floating
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-27 10:13 UTC by Julian Maurice
Modified: 2024-05-03 12:21 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33075: Add ability to mark an item as floating (7.80 KB, patch)
2023-02-27 10:14 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-27 10:13:14 UTC

    
Comment 1 Julian Maurice 2023-02-27 10:14:01 UTC
Created attachment 147428 [details] [review]
Bug 33075: Add ability to mark an item as floating

Test plan:
1. Run updatedatabase.pl, update_dbix_class_files.pl and restart koha
2. Go to "Admin > Koha to MARC mapping" and map items.floating to an
   item subfield
3. Create an item.
4. Make sure that your configuration allows to check out this item, and
   when returned to a different library the item should be transfered
   back to its home library.
5. Check out this item and return it in a different library. It should
   be transfered. Check in the item in its home library to complete the
   transfer.
6. Modify the item and in the "floating" subfield put a value different
   than "0"
7. Check out this item and return it in a different library. There
   should be no transfer. Item's holding library should be the library
   where it has been returned
Comment 2 Fridolin Somers 2023-03-06 06:48:51 UTC
installer/data/mysql/atomicupdate/bug-XXXXX.pl needs to use bug id 33075
Comment 3 Andrew Fuerste-Henry 2023-03-06 14:45:28 UTC
Your test plan assumes a circulation rule that doesn't allow floating, with the value in items.floating overriding such that it does. Is the opposite true? If my circ rules says everything should float, can I force specific items to *not* float by setting an items.floating value? This seems like it would best conform to existing circ rule structures if:
items.floating is NULL: item follows regular circ rules
items.floating = 0: item does not float, regardless of circ rules
items.floating = 1: item does float, regardless of circ rules
Comment 4 Julian Maurice 2023-03-06 14:59:25 UTC
> If my circ rules says everything should float, can I force specific items to
> *not* float by setting an items.floating value?

That's an interesting idea, but that's not what this patch does (items.floating is defined as NOT NULL).
Comment 5 Andrew Auld 2023-08-18 07:36:23 UTC
I may be being stupid, but in sandbox, I can't find items.floating in the Koha to MARC mapping table.
Comment 6 Emmi Takkinen 2023-08-21 05:46:07 UTC
(In reply to Andrew Auld from comment #5)
> I may be being stupid, but in sandbox, I can't find items.floating in the
> Koha to MARC mapping table.

Did you find it? If not, maybe restarting services helps?
Comment 7 Andrew Auld 2023-08-21 11:38:27 UTC
(In reply to Emmi Takkinen from comment #6)
> > I can't find items.floating in the
> > Koha to MARC mapping table.
> 
> Did you find it? If not, maybe restarting services helps?

Unfortunately not.
Comment 8 Fridolin Somers 2023-10-06 00:39:42 UTC
Is this somehow linked to Bug 9525 ?
Comment 9 Andrew Fuerste-Henry 2023-10-06 16:01:11 UTC
(In reply to Fridolin Somers from comment #8)
> Is this somehow linked to Bug 9525 ?

It seems like the changes in 9525 will require changes here, yeah. This patch treats floating rules as a binary, either on or off. Bug 9525 added a third option that is not represented here.
Comment 10 Fridolin Somers 2024-05-03 12:21:05 UTC
Needs a patch on REST API 
api/v1/swagger/definitions/item.yaml