In German at least, a quote in the sense of a "quote of the day" and a quote for something I want to buy/order are different thing that require different translation. It would be great if we could add context to those labels where just "Quotes" is used. koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt:322 koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt:107
Created attachment 147474 [details] [review] Bug 33076: Add context to "Quotes" A quote as a part of quoted text and a quote as part of the acquisition process need to be translated differently at least in German. This patch adds context to the terms, so we can do that. To test: * Go to Tools > Quote editor * Verify the heading of the page reads "Quotes" * Enable EDIFACT system preference * Go to Administration > EDI accounts * Add a new account save * Verify the table heading reads "Quotes" * Apply patch - nothing should change Verify the translation process: * Run: gulp po:update --lang de-DE * Verify the "Quotes" appear now separated by different context in misc/translator/po/de-DE-messages.po
Created attachment 147505 [details] [review] Bug 33076: Add context to "Quotes" A quote as a part of quoted text and a quote as part of the acquisition process need to be translated differently at least in German. This patch adds context to the terms, so we can do that. To test: * Go to Tools > Quote editor * Verify the heading of the page reads "Quotes" * Enable EDIFACT system preference * Go to Administration > EDI accounts * Add a new account save * Verify the table heading reads "Quotes" * Apply patch - nothing should change Verify the translation process: * Run: gulp po:update --lang de-DE * Verify the "Quotes" appear now separated by different context in misc/translator/po/de-DE-messages.po Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 148234 [details] [review] Bug 33076: Add context to "Quotes" A quote as a part of quoted text and a quote as part of the acquisition process need to be translated differently at least in German. This patch adds context to the terms, so we can do that. To test: * Go to Tools > Quote editor * Verify the heading of the page reads "Quotes" * Enable EDIFACT system preference * Go to Administration > EDI accounts * Add a new account save * Verify the table heading reads "Quotes" * Apply patch - nothing should change Verify the translation process: * Run: gulp po:update --lang de-DE * Verify the "Quotes" appear now separated by different context in misc/translator/po/de-DE-messages.po Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I think this is OK.. I wasn't 100% sure about the EDI template change.. QUOTES is a type of edi message in this context.. but it may well be translated too...? Anyway.. I reckon we can PQA.
Martin, Do you mean that EDI's "Quotes" should have it's own context vs other "price submissions"? Or that the context "price submissions" is not correct at all? Caroline
We could also make it "EDIFACT message QUOTE" maybe?
(In reply to Katrin Fischer from comment #6) > We could also make it "EDIFACT message QUOTE" maybe? That makes sense, I think. I wasn't entirely sure, really.. it's a technical term as a posed to a accounting one in this case so hopefully it'll help the translators understand.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Created attachment 148388 [details] [review] Bug 33076: (QA follow-up) Update context hint to "EDIFACT message QUOTE" As discussed on the bug, this updates the hint to make it easier for translators to decide on the correct translation.
Tomas, could you push this small follow-up?
Follow-up pushed to master.
Follow-up pushed to 22.11.x, keywords removed
Backported to 22.05.x for upcoming 22.05.12
This bug doesn't apply fine on 21.11.x... can you provide a backport if needed? Thx!