Bug 33090 - page-sections are missing in the account line details page
Summary: page-sections are missing in the account line details page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 31757
  Show dependency treegraph
 
Reported: 2023-02-28 16:33 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 33090: Add page-section to accountline-details (1.62 KB, patch)
2023-02-28 16:41 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33090: Add page-section to accountline-details (18.24 KB, patch)
2023-03-01 13:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33090: Add page-section to accountline-details (18.29 KB, patch)
2023-03-04 13:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-02-28 16:33:41 UTC

    
Comment 1 Martin Renvoize 2023-02-28 16:41:28 UTC
Created attachment 147506 [details] [review]
Bug 33090: Add page-section to accountline-details

This patch adds page-section containers to the accountlines details
display page.

I'm not really sure I like the appearance yet.. input welcome.
Comment 2 Katrin Fischer 2023-02-28 16:50:52 UTC
Thx for filing :)
Comment 3 Owen Leonard 2023-03-01 13:51:33 UTC
Created attachment 147561 [details] [review]
Bug 33090: Add page-section to accountline-details

This patch adds page-section containers to the accountlines details
display page.

Note: This patch contains whitespace changes, so use diff accordingly.

To test, apply the patch and locate a patron with charges on their
account (lost item fee, account renewal fee, overdue fine, etc).

- From the patron detail page, click the "Accounting" tab in the sidebar
  menu.
- Click the "Transactions" tab.
- Click the "Details" button for an individual charge.
- On the transaction detail page, confirm that the page sections look
  correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2023-03-01 13:52:38 UTC
I think this change is logical and consistent. To keep things muddy I fixed some indentation and added markup comments. And wrote a test plan. I hope that's okay!
Comment 5 Katrin Fischer 2023-03-04 13:40:17 UTC
Created attachment 147757 [details] [review]
Bug 33090: Add page-section to accountline-details

This patch adds page-section containers to the accountlines details
display page.

Note: This patch contains whitespace changes, so use diff accordingly.

To test, apply the patch and locate a patron with charges on their
account (lost item fee, account renewal fee, overdue fine, etc).

- From the patron detail page, click the "Accounting" tab in the sidebar
  menu.
- Click the "Transactions" tab.
- Click the "Details" button for an individual charge.
- On the transaction detail page, confirm that the page sections look
  correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-03-10 13:24:05 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-10 16:37:30 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-03-14 20:29:12 UTC
Not needed in 22.05.x, no backport