Bug 33111 - Use template wrapper for breadcrumbs: Administration part 4
Summary: Use template wrapper for breadcrumbs: Administration part 4
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-01 20:14 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 (32.16 KB, patch)
2023-03-02 13:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 (32.22 KB, patch)
2023-03-29 11:33 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33111: (QA follow-up) Add more context to breadcrumb parts for easier translation (2.50 KB, patch)
2023-04-08 22:49 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-01 20:14:02 UTC
To continue the process started by Bug 32507, this patch will update several more templates in administration so that they use the new template wrapper for breadcrumbs.

- edi_ean_accounts.tt
- identity_provider_domains.tt
- identity_providers.tt
- item_circulation_alerts.tt
- items_search_field.tt
- items_search_fields.tt
- itemtypes.tt
- koha2marclinks.tt
- library_groups.tt
- marc_subfields_structure.tt
- marctagstructure.tt
- matching-rules.tt
Comment 1 Owen Leonard 2023-03-02 13:33:14 UTC
Created attachment 147616 [details] [review]
Bug 33111: Use template wrapper for breadcrumbs: Administration part 4

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
  - Library EANs (list, new, edit, confirm delete)
  - Identity providers (list, new, edit)
    - Manage domains (list, new, edit)
  - Item circulation alerts
  - Item search fields (list, new, edit)
  - Item types (list, new, edit, delete confirm)
  - Koha to MARC mapping
  - Library groups
  - MARC frameworks ->
    -> Actions -> MARC structure (list, new, edit, delete confirm)
       -> View, edit, and delete confirm
  - Record matching rules (list, new, edit, delete confirm)
Comment 2 PTFS Europe Sandboxes 2023-03-29 11:33:35 UTC
Created attachment 148903 [details] [review]
Bug 33111: Use template wrapper for breadcrumbs: Administration part 4

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
  - Library EANs (list, new, edit, confirm delete)
  - Identity providers (list, new, edit)
    - Manage domains (list, new, edit)
  - Item circulation alerts
  - Item search fields (list, new, edit)
  - Item types (list, new, edit, delete confirm)
  - Koha to MARC mapping
  - Library groups
  - MARC frameworks ->
    -> Actions -> MARC structure (list, new, edit, delete confirm)
       -> View, edit, and delete confirm
  - Record matching rules (list, new, edit, delete confirm)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 22:49:43 UTC
Created attachment 149332 [details] [review]
Bug 33111: (QA follow-up) Add more context to breadcrumb parts for easier translation

With the new wrappers we will translate every part of the
breadcrumb as a separate string and only once. So single words
like 'new' can be problematic in translation.

This changes:
* New > New identity provider
* Edit > Edit identity provider
* (Item search fields) <name of search field> > Edit <name of search field>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 14:44:20 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:02 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.