Bug 33129 - Use template wrapper for breadcrumbs: Administration part 6
Summary: Use template wrapper for breadcrumbs: Administration part 6
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-03 15:55 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:


Attachments
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 (18.17 KB, patch)
2023-03-03 17:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 (18.23 KB, patch)
2023-03-29 13:52 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 (18.29 KB, patch)
2023-04-08 22:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-03 15:55:05 UTC
To continue the process started by Bug 32507, this patch will update several more templates in administration so that they use the new template wrapper for breadcrumbs.

 - admin/share_content.tt
 - admin/smart-rules.tt
 - admin/sms_providers.tt
 - admin/smtp_servers.tt
 - admin/systempreferences.tt
 - admin/transfer_limits.tt
 - admin/transport-cost-matrix.tt
 - admin/usage_statistics.tt
 - admin/z3950servers.tt
 - admin/searchengine/elasticsearch/mappings.tt
Comment 1 Owen Leonard 2023-03-03 17:14:38 UTC
Created attachment 147719 [details] [review]
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Search engine configuration (Elasticsearch)
 - Share content with Mana KB
 - Circulation and fine rules
 - SMS cellular providers (SMSSendDriver preference must be set)
 - System preferences -> Local use (list, add, edit, confirm delete)
 - Library transfer limits (Advanced editor)
 - Transport cost matrix
 - Usage statistics
 - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and
   SRU servers)
Comment 2 Andrew Auld 2023-03-29 12:11:13 UTC
In testing this, everything works as it should.

However, for the SMS cellular providers, when I click 'New SMS Provider' the breadcrumb doesn't add another crumb 'New SMS Provider'. This means that I can't easily use the breadcrumb to go back to the SMS Provider list page.

Similarly, when I edit an SMS Provider that I have added, the breadcrumb also doesn't add another crumb eg 'Modify SMS Provider <SMS Provider name>'. Again, this makes it difficult to exit the edit page back to the list page using the breadcrumb links.

I am not sure whether this should be fixed as part of this bug or added as a new bug.
Comment 3 Owen Leonard 2023-03-29 13:02:21 UTC
(In reply to Andrew Auld from comment #2)
> However, for the SMS cellular providers, when I click 'New SMS Provider' the
> breadcrumb doesn't add another crumb 'New SMS Provider'

Since the behavior you describe is in master as well I would prefer that this be addressed in another bug.

Currently we don't have an established method of updating elements like breadcrumbs and page titles when the content of the page changes without a page reload
Comment 4 PTFS Europe Sandboxes 2023-03-29 13:52:01 UTC
Created attachment 148920 [details] [review]
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Search engine configuration (Elasticsearch)
 - Share content with Mana KB
 - Circulation and fine rules
 - SMS cellular providers (SMSSendDriver preference must be set)
 - System preferences -> Local use (list, add, edit, confirm delete)
 - Library transfer limits (Advanced editor)
 - Transport cost matrix
 - Usage statistics
 - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and
   SRU servers)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 5 Andrew Auld 2023-03-29 13:56:43 UTC
OK I have signed this off and reached out to Martin to help me create a bug relating to the SMS breadcrumb thing.
Comment 6 Katrin Fischer 2023-04-08 22:28:06 UTC
Created attachment 149330 [details] [review]
Bug 33129: Use template wrapper for breadcrumbs: Administration part 6

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

Administration ->
 - Search engine configuration (Elasticsearch)
 - Share content with Mana KB
 - Circulation and fine rules
 - SMS cellular providers (SMSSendDriver preference must be set)
 - System preferences -> Local use (list, add, edit, confirm delete)
 - Library transfer limits (Advanced editor)
 - Transport cost matrix
 - Usage statistics
 - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and
   SRU servers)

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-04-14 18:39:12 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-04-18 12:19:49 UTC
Nice work everyone!

Pushed to stable for 22.11.x