Bug 33130 - Use template wrapper for breadcrumbs: Authorities
Summary: Use template wrapper for breadcrumbs: Authorities
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-03 17:31 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33130: Use template wrapper for breadcrumbs: Authorities (7.79 KB, patch)
2023-03-03 18:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33130: Use template wrapper for breadcrumbs: Authorities (7.84 KB, patch)
2023-03-07 03:44 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 33130: Use template wrapper for breadcrumbs: Authorities (7.90 KB, patch)
2023-04-08 22:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-03 17:31:44 UTC
To continue the process started by Bug 32507, this patch will update several authorities templates so that they use the new template wrapper for breadcrumbs.

 - authorities/authorities-home.tt
 - authorities/authorities.tt
 - authorities/detail.tt
 - authorities/merge.tt
 - authorities/searchresultlist.tt
Comment 1 Owen Leonard 2023-03-03 18:45:52 UTC
Created attachment 147723 [details] [review]
Bug 33130: Use template wrapper for breadcrumbs: Authorities

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Authorities home page
  - Authority search results
  - Authority detail
  - Authority add/edit
  - Authority merge
Comment 2 Phil Ringnalda 2023-03-07 03:44:07 UTC
Created attachment 147816 [details] [review]
Bug 33130: Use template wrapper for breadcrumbs: Authorities

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Authorities home page
  - Authority search results
  - Authority detail
  - Authority add/edit
  - Authority merge

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Katrin Fischer 2023-04-08 22:23:29 UTC
Created attachment 149329 [details] [review]
Bug 33130: Use template wrapper for breadcrumbs: Authorities

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Authorities home page
  - Authority search results
  - Authority detail
  - Authority add/edit
  - Authority merge

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-12 14:22:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:06 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.