Bug 33131 - Use template wrapper for breadcrumbs: Catalog part 1
Summary: Use template wrapper for breadcrumbs: Catalog part 1
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507
Blocks: 33460
  Show dependency tree / graph
 
Reported: 2023-03-03 18:52 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 (13.93 KB, patch)
2023-03-03 19:18 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 (13.99 KB, patch)
2023-03-29 09:24 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 (14.04 KB, patch)
2023-04-08 22:19 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-03 18:52:56 UTC 
To continue the process started by Bug 32507, this patch will update several catalog templates so that they use the new template wrapper for breadcrumbs.

 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/imageviewer.tt
 - catalogue/ISBDdetail.tt
 - catalogue/issuehistory.tt
 - catalogue/itemsearch.tt
 - catalogue/labeledMARCdetail.tt
 - catalogue/MARCdetail.tt
 - catalogue/moredetail.tt
 - catalogue/results.tt
Comment 1 Owen Leonard 2023-03-03 19:18:40 UTC 
Created attachment 147728 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search
Comment 2 PTFS Europe Sandboxes 2023-03-29 09:24:50 UTC 
Created attachment 148893 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-04-08 22:19:24 UTC 
Created attachment 149328 [details] [review]
Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1

This patch updates several catalog templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Advanced search
- Bibliographic detail page
- Labeled MARC detail page
- MARC detail page
- ISBD detail page
- Item detail page
- Image detail view (with LocalCoverImages enabled and a custom cover
  added)
- Checkout history
- Item search

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-12 14:22:47 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:46:09 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.