Bug 33133 - Fast cataloging should be visible in cataloging
Summary: Fast cataloging should be visible in cataloging
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-03 20:23 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33133: Add fast cataloging to 'Cataloging' page (4.87 KB, patch)
2023-03-03 20:30 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33133: Add fast cataloging to 'Cataloging' page (4.94 KB, patch)
2023-03-07 13:11 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33133: Move fast cataloging to first column (2.56 KB, patch)
2023-03-14 13:37 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33133: Add fast cataloging to 'Cataloging' page (5.00 KB, patch)
2023-03-15 18:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33133: Move fast cataloging to first column (2.62 KB, patch)
2023-03-15 18:11 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-03-03 20:23:06 UTC
If a user has only 'fast cataloging' permission they should still see the Cataloging link on the home page, and be able to see a link for fast cataloging.

Currently, if you have only fast cataloging (and staffaccess) you can brose to cataloging.pl, but you get a blank page
Comment 1 Nick Clemens 2023-03-03 20:30:23 UTC
Created attachment 147739 [details] [review]
Bug 33133: Add fast cataloging to 'Cataloging' page

This patch adds a check for the existence of the Fast Add framework to
the Koha mainpage and the cataloging home page

If it exists, and the user has fast cataloging permission then there
will be a link to Cataloging on the home page, and to Fast add on the
cataloging page

To test:
1 - Have two patrons, one with superlibrarian and one with only
  catalogue + fast_cataloging
2 - Make sure you have a fast add framework (code:FA)
3 - Have two windows/tabs one with each patron (one private/incognito or
  use two browsers)
4 - View mainpage.pl for both
5 - Superlibrarian has Catalogue link, other does not
6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl
7 - Superlibrarian sees stuff, other can access page, but has no buttons
8 - Apply patch
9 - Repeat 4 - both have a link
10 - Repeat 7 - both have a link to fast add
11 - Confirm fast add link works
Comment 2 ByWater Sandboxes 2023-03-07 13:11:54 UTC
Created attachment 147837 [details] [review]
Bug 33133: Add fast cataloging to 'Cataloging' page

This patch adds a check for the existence of the Fast Add framework to
the Koha mainpage and the cataloging home page

If it exists, and the user has fast cataloging permission then there
will be a link to Cataloging on the home page, and to Fast add on the
cataloging page

To test:
1 - Have two patrons, one with superlibrarian and one with only
  catalogue + fast_cataloging
2 - Make sure you have a fast add framework (code:FA)
3 - Have two windows/tabs one with each patron (one private/incognito or
  use two browsers)
4 - View mainpage.pl for both
5 - Superlibrarian has Catalogue link, other does not
6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl
7 - Superlibrarian sees stuff, other can access page, but has no buttons
8 - Apply patch
9 - Repeat 4 - both have a link
10 - Repeat 7 - both have a link to fast add
11 - Confirm fast add link works

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-03-07 13:13:16 UTC
Works as described, thanks for the patch.
Comment 4 Katrin Fischer 2023-03-09 22:23:28 UTC
2 things:

1) Why check for the existance of the FA framework on the staff interface start page, but not on the cataloguing start page?

2) I don't feel like Fast cataloguing is a tool and it gets really lost in the 3rd column. Maybe we could move it into the first column on top or even into the toolbar of the cataloging page?
Comment 5 Nick Clemens 2023-03-14 13:37:04 UTC
Created attachment 148165 [details] [review]
Bug 33133: Move fast cataloging to first column

This move the link and adds its own heading
Comment 6 Nick Clemens 2023-03-14 13:38:20 UTC
(In reply to Katrin Fischer from comment #4)
> 2 things:
> 
> 1) Why check for the existance of the FA framework on the staff interface
> start page, but not on the cataloguing start page?

I do test:
in script:
$template->param( fast_cataloging => 1 ) if $frameworks->find({ frameworkcode => 'FA' });
in template:
( fast_cataloging && CAN_user_editcatalogue_fast_cataloging   )

 
> 2) I don't feel like Fast cataloguing is a tool and it gets really lost in
> the 3rd column. Maybe we could move it into the first column on top or even
> into the toolbar of the cataloging page?

Moved to first column
Comment 7 Martin Renvoize 2023-03-15 18:11:31 UTC
Created attachment 148241 [details] [review]
Bug 33133: Add fast cataloging to 'Cataloging' page

This patch adds a check for the existence of the Fast Add framework to
the Koha mainpage and the cataloging home page

If it exists, and the user has fast cataloging permission then there
will be a link to Cataloging on the home page, and to Fast add on the
cataloging page

To test:
1 - Have two patrons, one with superlibrarian and one with only
  catalogue + fast_cataloging
2 - Make sure you have a fast add framework (code:FA)
3 - Have two windows/tabs one with each patron (one private/incognito or
  use two browsers)
4 - View mainpage.pl for both
5 - Superlibrarian has Catalogue link, other does not
6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl
7 - Superlibrarian sees stuff, other can access page, but has no buttons
8 - Apply patch
9 - Repeat 4 - both have a link
10 - Repeat 7 - both have a link to fast add
11 - Confirm fast add link works

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2023-03-15 18:11:33 UTC
Created attachment 148242 [details] [review]
Bug 33133: Move fast cataloging to first column

This move the link and adds its own heading

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2023-03-15 18:11:52 UTC
Nice fix, thanks Nick

Passing QA
Comment 10 Martin Renvoize 2023-03-15 18:14:00 UTC
Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here now :)
Comment 11 Katrin Fischer 2023-03-15 22:45:43 UTC
(In reply to Martin Renvoize from comment #10)
> Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here
> now :)

I was going to ask for another opinion anyway :)
Comment 12 Tomás Cohen Arazi 2023-03-27 10:47:47 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 13 Matt Blenkinsop 2023-04-11 10:55:11 UTC
Nice work everyone!

Pushed to stable for 22.11.x