If a user has only 'fast cataloging' permission they should still see the Cataloging link on the home page, and be able to see a link for fast cataloging. Currently, if you have only fast cataloging (and staffaccess) you can brose to cataloging.pl, but you get a blank page
Created attachment 147739 [details] [review] Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works
Created attachment 147837 [details] [review] Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works as described, thanks for the patch.
2 things: 1) Why check for the existance of the FA framework on the staff interface start page, but not on the cataloguing start page? 2) I don't feel like Fast cataloguing is a tool and it gets really lost in the 3rd column. Maybe we could move it into the first column on top or even into the toolbar of the cataloging page?
Created attachment 148165 [details] [review] Bug 33133: Move fast cataloging to first column This move the link and adds its own heading
(In reply to Katrin Fischer from comment #4) > 2 things: > > 1) Why check for the existance of the FA framework on the staff interface > start page, but not on the cataloguing start page? I do test: in script: $template->param( fast_cataloging => 1 ) if $frameworks->find({ frameworkcode => 'FA' }); in template: ( fast_cataloging && CAN_user_editcatalogue_fast_cataloging ) > 2) I don't feel like Fast cataloguing is a tool and it gets really lost in > the 3rd column. Maybe we could move it into the first column on top or even > into the toolbar of the cataloging page? Moved to first column
Created attachment 148241 [details] [review] Bug 33133: Add fast cataloging to 'Cataloging' page This patch adds a check for the existence of the Fast Add framework to the Koha mainpage and the cataloging home page If it exists, and the user has fast cataloging permission then there will be a link to Cataloging on the home page, and to Fast add on the cataloging page To test: 1 - Have two patrons, one with superlibrarian and one with only catalogue + fast_cataloging 2 - Make sure you have a fast add framework (code:FA) 3 - Have two windows/tabs one with each patron (one private/incognito or use two browsers) 4 - View mainpage.pl for both 5 - Superlibrarian has Catalogue link, other does not 6 - Browse to http://localhost:8081/cgi-bin/koha/cataloguing/cataloging-home.pl 7 - Superlibrarian sees stuff, other can access page, but has no buttons 8 - Apply patch 9 - Repeat 4 - both have a link 10 - Repeat 7 - both have a link to fast add 11 - Confirm fast add link works Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 148242 [details] [review] Bug 33133: Move fast cataloging to first column This move the link and adds its own heading Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice fix, thanks Nick Passing QA
Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here now :)
(In reply to Martin Renvoize from comment #10) > Ooops, I stole your QA Katrin.. apologies.. it's all looking good to me here > now :) I was going to ask for another opinion anyway :)
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x