Bug 33136 - Catalog search pop-up is missing page-section
Summary: Catalog search pop-up is missing page-section
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Clemens Tubach
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2023-03-04 15:08 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 33136: Added class "page-section" to the result page table of serial record search (1.31 KB, patch)
2023-03-30 12:38 UTC, Clemens Tubach 		Details | Diff | Splinter Review
Bug 33136: Added class "page-section" to the result page table of serial record search (1.37 KB, patch)
2023-03-30 13:33 UTC, Jan Kissig 		Details | Diff | Splinter Review
Bug 33136: Added class "page-section" to the result page table of serial record search (1.43 KB, patch)
2023-03-30 13:57 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-03-04 15:08:04 UTC 
Create a new subscription and for creating the link to an existing record, click on the "Search for record" link. Search for an existing record - the result list is missing the page section.
Comment 1 Martin Renvoize (ashimema) 2023-03-17 10:29:10 UTC 
Did you fancy me walking you through submitting a patch for this one Aude?
Comment 2 Clemens Tubach 2023-03-30 12:38:18 UTC 
Created attachment 148980 [details] [review]
Bug 33136: Added class "page-section" to the result page table of serial record search

Added class "page-section" to the result page table of serial record search to fit into the new staff design.

To test:
- Go to serials
- Create a new subscription
- Click o nzthe "Search for Record" link
- Search for something (example: e)
- Verify the result table
- Apply the patch
- Repeat the steps
- The result table should have the correct background
Comment 3 Jan Kissig 2023-03-30 13:33:55 UTC 
Created attachment 148990 [details] [review]
Bug 33136: Added class "page-section" to the result page table of serial record search

Added class "page-section" to the result page table of serial record search to fit into the new staff design.

To test:
- Go to serials
- Create a new subscription
- Click o nzthe "Search for Record" link
- Search for something (example: e)
- Verify the result table
- Apply the patch
- Repeat the steps
- The result table should have the correct background

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Comment 4 Martin Renvoize (ashimema) 2023-03-30 13:57:55 UTC 
Created attachment 148991 [details] [review]
Bug 33136: Added class "page-section" to the result page table of serial record search

Added class "page-section" to the result page table of serial record search to fit into the new staff design.

To test:
- Go to serials
- Create a new subscription
- Click o nzthe "Search for Record" link
- Search for something (example: e)
- Verify the result table
- Apply the patch
- Repeat the steps
- The result table should have the correct background

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2023-03-30 13:58:38 UTC 
Yeay, Jan.

Thanks for the patch.. passing QA
Comment 6 Tomás Cohen Arazi (tcohen) 2023-03-30 15:13:40 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-04-11 11:20:06 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-04-24 17:18:00 UTC 
Not needed for 22.05.x, no backport.