The information visible on the transactions and 'pay fines' tabs is drifting apart with different columns visible on each. It would be nice to make them consistent again.
* home library * call number (bug 32977)
Created attachment 147967 [details] [review] Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column.
Created attachment 147968 [details] [review] Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column.
Created attachment 147990 [details] [review] Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 147991 [details] [review] Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Note: to test, make sure you apply bug 32977 first. The only thing I noticed is that in table settings, the column names differ. In Patron > account-fines, the column name is: home_library With this patch, in Patron > pay, the column name is: homebranch Should the two column names match? Otherwise, this works as described, so signing off - thanks for the patch.
Created attachment 148000 [details] [review] Bug 33137: Make column names match
(In reply to Sally from comment #6) > Note: to test, make sure you apply bug 32977 first. > > The only thing I noticed is that in table settings, the column names differ. > > In Patron > account-fines, the column name is: home_library > > With this patch, in Patron > pay, the column name is: homebranch > > Should the two column names match? > > Otherwise, this works as described, so signing off - thanks for the patch. I added a follow-up to make the column names match as 'home_library'. Thanks Sally!
Created attachment 148001 [details] [review] Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 148002 [details] [review] Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 148003 [details] [review] Bug 33137: Make column names match Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
(In reply to Lucas Gass from comment #8) > I added a follow-up to make the column names match as 'home_library'. > > Thanks Sally! Awesome, thanks Lucas! I retested with the follow up and all is working well.
Created attachment 148236 [details] [review] Bug 33137: Add Home library to pay-fines-table and table settings To test: 1. Apply patch and restart_All 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 148237 [details] [review] Bug 33137: Add call number to pay-fines-table and table settings To test: 1. Apply patch and restart_all 2. From a patron's Accounting tab add some invoices that are related to an item. 3. From the 'Make a payemnt' notice the new Call number column. 4. Using Table settings, make sure you can properly hide the column. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 148238 [details] [review] Bug 33137: Make column names match Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work everyone, Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.12
applied to 21.11.x for 21.11.20
There are 2 columns missing in the footer: https://snipboard.io/vyBt2F.jpg