147 is a main heading tag, like the other 1xx ones, so there should only be one visible per authority framework, and it should only be in a NAME_EVENT framework, which we don't ship.
Created attachment 147768 [details] [review] Bug 33138: Don't copy tag 147 to authority MARC frameworks We shouldn't be including tag 147 in every authority MARC framework we install, since like all 1xx authority tags there should only be one per record. It only belongs in a NAME_EVENT framework, which we don't install. Test plan: 1. Apply patch, kd && ku or however you like to restart 2. Administration - Authority types - Actions button for Default - MARC structure 3. In the search box below the text "Select an authority framework" enter 147 and click OK 4. Once you see that it exists in Default, switch the dropdown to each of the other frameworks and verify it doesn't appear in any.
Created attachment 149706 [details] [review] Bug 33138: Don't copy tag 147 to authority MARC frameworks We shouldn't be including tag 147 in every authority MARC framework we install, since like all 1xx authority tags there should only be one per record. It only belongs in a NAME_EVENT framework, which we don't install. Test plan: 1. Apply patch, kd && ku or however you like to restart 2. Administration - Authority types - Actions button for Default - MARC structure 3. In the search box below the text "Select an authority framework" enter 147 and click OK 4. Once you see that it exists in Default, switch the dropdown to each of the other frameworks and verify it doesn't appear in any. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. To reload the authority frameworks after apply the patch in KTD: reset_all
Created attachment 150364 [details] [review] Bug 33138: Don't copy tag 147 to authority MARC frameworks We shouldn't be including tag 147 in every authority MARC framework we install, since like all 1xx authority tags there should only be one per record. It only belongs in a NAME_EVENT framework, which we don't install. Test plan: 1. Apply patch, kd && ku or however you like to restart 2. Administration - Authority types - Actions button for Default - MARC structure 3. In the search box below the text "Select an authority framework" enter 147 and click OK 4. Once you see that it exists in Default, switch the dropdown to each of the other frameworks and verify it doesn't appear in any. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I wondered if there should be a DB update, but I don't think we want to remove things from existing frameworks
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x