Bug 33138 - Don't copy tag 147 to all MARC frameworks, since it should only be used in a separate NAME_EVENT framework
Summary: Don't copy tag 147 to all MARC frameworks, since it should only be used in a ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Phil Ringnalda
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-05 03:25 UTC by Phil Ringnalda
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07


Attachments
Bug 33138: Don't copy tag 147 to authority MARC frameworks (9.51 KB, patch)
2023-03-05 03:38 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 33138: Don't copy tag 147 to authority MARC frameworks (9.56 KB, patch)
2023-04-14 19:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 33138: Don't copy tag 147 to authority MARC frameworks (9.61 KB, patch)
2023-04-28 11:40 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2023-03-05 03:25:39 UTC
147 is a main heading tag, like the other 1xx ones, so there should only be one visible per authority framework, and it should only be in a NAME_EVENT framework, which we don't ship.
Comment 1 Phil Ringnalda 2023-03-05 03:38:35 UTC
Created attachment 147768 [details] [review]
Bug 33138: Don't copy tag 147 to authority MARC frameworks

We shouldn't be including tag 147 in every authority MARC framework we
install, since like all 1xx authority tags there should only be
one per record. It only belongs in a NAME_EVENT framework, which we
don't install.

Test plan:

1. Apply patch, kd && ku or however you like to restart
2. Administration - Authority types - Actions button for Default
   - MARC structure
3. In the search box below the text "Select an authority framework"
   enter 147 and click OK
4. Once you see that it exists in Default, switch the dropdown to
   each of the other frameworks and verify it doesn't appear in
   any.
Comment 2 David Nind 2023-04-14 19:21:25 UTC
Created attachment 149706 [details] [review]
Bug 33138: Don't copy tag 147 to authority MARC frameworks

We shouldn't be including tag 147 in every authority MARC framework we
install, since like all 1xx authority tags there should only be
one per record. It only belongs in a NAME_EVENT framework, which we
don't install.

Test plan:

1. Apply patch, kd && ku or however you like to restart
2. Administration - Authority types - Actions button for Default
   - MARC structure
3. In the search box below the text "Select an authority framework"
   enter 147 and click OK
4. Once you see that it exists in Default, switch the dropdown to
   each of the other frameworks and verify it doesn't appear in
   any.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-14 19:22:28 UTC
Testing notes (using KTD):

1. To reload the authority frameworks after apply the patch in KTD: reset_all
Comment 4 Nick Clemens 2023-04-28 11:40:03 UTC
Created attachment 150364 [details] [review]
Bug 33138: Don't copy tag 147 to authority MARC frameworks

We shouldn't be including tag 147 in every authority MARC framework we
install, since like all 1xx authority tags there should only be
one per record. It only belongs in a NAME_EVENT framework, which we
don't install.

Test plan:

1. Apply patch, kd && ku or however you like to restart
2. Administration - Authority types - Actions button for Default
   - MARC structure
3. In the search box below the text "Select an authority framework"
   enter 147 and click OK
4. Once you see that it exists in Default, switch the dropdown to
   each of the other frameworks and verify it doesn't appear in
   any.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens 2023-04-28 11:43:37 UTC
I wondered if there should be a DB update, but I don't think we want to remove things from existing frameworks
Comment 6 Tomás Cohen Arazi 2023-05-18 14:35:59 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-06-08 16:51:48 UTC
Nice work everyone!

Pushed to stable for 22.11.x