Bug 33149 - Use template wrapper for breadcrumbs: Circulation part 1
Summary: Use template wrapper for breadcrumbs: Circulation part 1
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Nick Clemens
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-06 15:06 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 (12.87 KB, patch)
2023-03-06 17:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 (12.93 KB, patch)
2023-03-29 10:59 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 (12.98 KB, patch)
2023-04-01 23:11 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-06 15:06:52 UTC
To continue the process started by Bug 32507, this patch will update some circulation templates so that they use the new template wrapper for breadcrumbs.

 - circ/article-requests.tt
 - circ/bookcount.tt
 - circ/branchoverdues.tt
 - circ/branchtransfers.tt
 - circ/checkout-notes.tt
 - circ/circulation_batch_checkouts.tt
 - circ/circulation-home.tt
Comment 1 Owen Leonard 2023-03-06 17:24:29 UTC
Created attachment 147793 [details] [review]
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

The patch also makes a minor change to bookcount.pl to allow for correct
display of the record title using the biblio-title include.

Navigation context for bookcount.tt has been changed to "catalog" from
"circulation" because the page is linked to from a catalog-related page.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation home page
  - Checkout notes
  - Article requests
  - Transfer
  - Overdues with fines
  - Check out -> Check out to patron ->
    - Batch check out
- Catalog -> Search -> Bibliographic record -> Items
  - View item's checkout history. The updated page should show this new
    breadcrumb sequence: Home -> Catalog -> [title] -> Items ->
    Circulation statistics
Comment 2 Biblibre Sandboxes 2023-03-29 10:59:48 UTC
Created attachment 148901 [details] [review]
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

The patch also makes a minor change to bookcount.pl to allow for correct
display of the record title using the biblio-title include.

Navigation context for bookcount.tt has been changed to "catalog" from
"circulation" because the page is linked to from a catalog-related page.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation home page
  - Checkout notes
  - Article requests
  - Transfer
  - Overdues with fines
  - Check out -> Check out to patron ->
    - Batch check out
- Catalog -> Search -> Bibliographic record -> Items
  - View item's checkout history. The updated page should show this new
    breadcrumb sequence: Home -> Catalog -> [title] -> Items ->
    Circulation statistics

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Nick Clemens 2023-04-01 23:11:21 UTC
Created attachment 149071 [details] [review]
Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

The patch also makes a minor change to bookcount.pl to allow for correct
display of the record title using the biblio-title include.

Navigation context for bookcount.tt has been changed to "catalog" from
"circulation" because the page is linked to from a catalog-related page.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation home page
  - Checkout notes
  - Article requests
  - Transfer
  - Overdues with fines
  - Check out -> Check out to patron ->
    - Batch check out
- Catalog -> Search -> Bibliographic record -> Items
  - View item's checkout history. The updated page should show this new
    breadcrumb sequence: Home -> Catalog -> [title] -> Items ->
    Circulation statistics

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2023-04-01 23:12:49 UTC
Probably we should move this page to the catalog folder, however, the permission  here is circ based, so it would be a bigger job and requires discussion. IN the context of breadcrumbs, the change makes sense and is small so passing QA
Comment 5 Tomás Cohen Arazi 2023-04-06 12:30:32 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 17:24:36 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.