Bug 33151 - Improve translation of strings in cities and circulation desk administration pages
Summary: Improve translation of strings in cities and circulation desk administration ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-06 18:01 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.12, 21.11.20


Attachments
Bug 33151: Improve translation of string in cities.tt and desks.tt (1.81 KB, patch)
2023-03-06 18:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33151: Improve translation of string in cities.tt and desks.tt (1.88 KB, patch)
2023-03-08 11:30 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33151: Improve translation of string in cities.tt and desks.tt (1.94 KB, patch)
2023-03-15 17:54 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-06 18:01:16 UTC
admin/cities.tt and admin/desks.tt share a similar problem with regard to translation:

#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:178
#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt:179
#, c-format
msgid "%s Searching: %s %s %s "
msgstr "%s Recherche : %s %s %s "

Wrapping this string with <span> in both templates will make it easier:

msgid "Searching: %s"
msgstr "Recherche"
Comment 1 Owen Leonard 2023-03-06 18:07:22 UTC
Created attachment 147796 [details] [review]
Bug 33151: Improve translation of string in cities.tt and desks.tt

This patch adds a <span> tag around a string in both cities.tt and
desks.tt in order to improve translatability.

To test apply the patch and run the translation script to update the .po
files, e.g.

perl misc/translator/translate update fr-FR

Check the updated .po files:
 - Before the patch you would have found 'msgid "%s Searching: %s %s %s'
 - After the patch you should find 'msgid "Searching: %s'
Comment 2 Matt Blenkinsop 2023-03-08 11:30:38 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2023-03-15 17:54:41 UTC
Created attachment 148235 [details] [review]
Bug 33151: Improve translation of string in cities.tt and desks.tt

This patch adds a <span> tag around a string in both cities.tt and
desks.tt in order to improve translatability.

To test apply the patch and run the translation script to update the .po
files, e.g.

perl misc/translator/translate update fr-FR

Check the updated .po files:
 - Before the patch you would have found 'msgid "%s Searching: %s %s %s'
 - After the patch you should find 'msgid "Searching: %s'

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-03-15 17:55:49 UTC
Breaking the rules a little here, QAing a patch one of my team signed off on.. But it's a trivial and clear improvement so I think we're safe.. I'll leave it to the RM to push back if he wants a further QA ;P

Passing QA
Comment 5 Katrin Fischer 2023-03-15 22:44:28 UTC
I am all ok with that :)(In reply to Martin Renvoize from comment #4)
> Breaking the rules a little here, QAing a patch one of my team signed off
> on.. But it's a trivial and clear improvement so I think we're safe.. I'll
> leave it to the RM to push back if he wants a further QA ;P
> 
> Passing QA

You got the QAM's ok there :)
Comment 6 Tomás Cohen Arazi 2023-03-17 13:00:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-17 17:21:07 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-04-24 16:33:50 UTC
Backported to 22.05.x for upcoming 22.05.12
Comment 9 Arthur Suzuki 2023-05-03 18:35:44 UTC
applied to 21.11.x for 21.11.20