Bug 33152 - Set focus for cursor to search input box when creating new report from "New SQL from Mana" option
Summary: Set focus for cursor to search input box when creating new report from "New S...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-06 20:38 UTC by Barbara Johnson
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Circulation function:


Attachments
Bug 33152: Add focus to search field (1.49 KB, patch)
2023-03-08 12:08 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33152: Add focus to search field (1.53 KB, patch)
2023-03-08 14:48 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 33152: Add focus to search field (1.58 KB, patch)
2023-03-09 22:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara Johnson 2023-03-06 20:38:14 UTC
When adding a report using Mana set the focus for the cursor to the search input box so that the user can just begin typing. It would eliminate an extra click and be more efficient for the user.
Comment 1 Matt Blenkinsop 2023-03-08 12:08:27 UTC
Created attachment 147901 [details] [review]
Bug 33152: Add focus to search field

This patch adds focus to the search field for a new SQL report from
mana.

Test plan:
1) Navigate to Reports > Create from SQL
2) Click on the new report dropdown and select "New SQL from Mana"
3) Observe that there is no focus on the input and the user needs to
   click to start typing
4) Apply patch
5) Repeat steps 1-2
6) There should now be focus on the input and typing can be started
   immediately
Comment 2 Lucas Gass (lukeg) 2023-03-08 14:48:51 UTC
Created attachment 147958 [details] [review]
Bug 33152: Add focus to search field

This patch adds focus to the search field for a new SQL report from
mana.

Test plan:
1) Navigate to Reports > Create from SQL
2) Click on the new report dropdown and select "New SQL from Mana"
3) Observe that there is no focus on the input and the user needs to
   click to start typing
4) Apply patch
5) Repeat steps 1-2
6) There should now be focus on the input and typing can be started
   immediately

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-03-09 22:02:17 UTC
Created attachment 148036 [details] [review]
Bug 33152: Add focus to search field

This patch adds focus to the search field for a new SQL report from
mana.

Test plan:
1) Navigate to Reports > Create from SQL
2) Click on the new report dropdown and select "New SQL from Mana"
3) Observe that there is no focus on the input and the user needs to
   click to start typing
4) Apply patch
5) Repeat steps 1-2
6) There should now be focus on the input and typing can be started
   immediately

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-10 13:24:08 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-10 16:32:41 UTC
Enhancement, not backporting to 22.11.x